Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect images to test that every opcode is getting parsed correctly #9

Closed
2 tasks done
NikolajSchlej opened this issue Nov 7, 2022 · 7 comments
Closed
2 tasks done

Comments

@NikolajSchlej
Copy link
Contributor

NikolajSchlej commented Nov 7, 2022

There are a lot (100+) of small parsers for both Framework and UEFI HII structures, and there are also a ton of images out there in the wild.
We need to ensure that every opcode that is possible in a firmware image is indeed parsed correctly, and if not, fix it.

  • Investigate UEFI VarStoreEfi opcode not getting parsed on some images
  • Build a collection of images covering as many UEFI and Framework opcodes as possible, probably with help of LVFS project (CC @hughsie)
@hughsie
Copy link

hughsie commented Nov 7, 2022

Happy to help; yell if you want me to run a script on my local mirror of firmware.

@NikolajSchlej
Copy link
Contributor Author

NikolajSchlej commented Nov 7, 2022

@hughsie, attaching the script, it takes a single -i /path/to/input_file.bin argument and generates a /path/to/input_file.bin.ifr.zip archive if everything goes as planned.
Please update the paths to UEFIExtract and IFRExtractor inside.
License: BSD 2-Clause.
extract_ifrs.py.zip

@NikolajSchlej NikolajSchlej self-assigned this Nov 7, 2022
@NikolajSchlej
Copy link
Contributor Author

@NikolajSchlej
Copy link
Contributor Author

@hughsie, got a chance to run that script above yet?
I'm now in full "let's prepare for the move to the US" mode, so I'll probably be out of the Internet for a while, might reply with significant delays.

@hughsie
Copy link

hughsie commented Nov 9, 2022

Hey, sorry; not yet. I've been dealing with fallout from that UEFI disclosure yesterday. Today hopefully.

@hughsie
Copy link

hughsie commented Nov 9, 2022

Script running, should be complete in about 5 hours (!)

@LongSoft LongSoft deleted a comment from hughsie Nov 10, 2022
@NikolajSchlej
Copy link
Contributor Author

Done investigating that collection, no parsing issues found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants