Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Enable backing image feature in Longhorn #2006

Closed
yasker opened this issue Nov 21, 2020 · 3 comments
Closed

[FEATURE] Enable backing image feature in Longhorn #2006

yasker opened this issue Nov 21, 2020 · 3 comments
Assignees
Labels
component/longhorn-manager Longhorn manager (control plane) kind/feature Feature request, new feature priority/0 Must be fixed in this release (managed by PO) require/auto-e2e-test Require adding/updating auto e2e test cases if they can be automated require/doc Require updating the longhorn.io documentation require/lep Require adding/updating enhancement proposal
Milestone

Comments

@yasker
Copy link
Member

yasker commented Nov 21, 2020

Longhorn Engine has the ability to use a qcow2 file as the backing image for the Longhorn volume. It was designed for VM but the feature was never implemented in Longhorn manager nor UI. We need to enable this feature for Harvester to use Longhorn with existing root images.

Btw, the field was called base image but it's better to rename everything into backing image because base image has become a standard Docker term.

Ref:
#1989 (comment)
harvester/harvester#227

@yasker yasker added component/longhorn-manager Longhorn manager (control plane) priority/0 Must be fixed in this release (managed by PO) require/auto-e2e-test Require adding/updating auto e2e test cases if they can be automated require/doc Require updating the longhorn.io documentation require/lep Require adding/updating enhancement proposal require/API-design labels Nov 21, 2020
@yasker yasker added this to the v1.2.0 milestone Nov 21, 2020
@yasker yasker modified the milestones: v1.2.0, v1.1.1 Dec 21, 2020
@yasker yasker added the kind/feature Feature request, new feature label Dec 21, 2020
shuo-wu pushed a commit to shuo-wu/longhorn that referenced this issue Dec 23, 2020
Longhorn longhorn#2006

Signed-off-by: Shuo Wu <shuo@rancher.com>
@yasker yasker changed the title [FEATURE] Enable backing file feature in Longhorn [FEATURE] Enable backing image feature in Longhorn Dec 24, 2020
shuo-wu pushed a commit to shuo-wu/longhorn that referenced this issue Dec 28, 2020
Longhorn longhorn#2006

Signed-off-by: Shuo Wu <shuo@rancher.com>
shuo-wu pushed a commit to shuo-wu/longhorn that referenced this issue Dec 28, 2020
Longhorn longhorn#2006

Signed-off-by: Shuo Wu <shuo@rancher.com>
@yasker yasker added the highlight Important feature/issue to highlight label Jan 8, 2021
shuo-wu pushed a commit to shuo-wu/longhorn that referenced this issue Jan 15, 2021
Longhorn longhorn#2006

Signed-off-by: Shuo Wu <shuo@rancher.com>
@longhorn-io-github-bot
Copy link

longhorn-io-github-bot commented Jan 25, 2021

Pre-merged Checklist

shuo-wu pushed a commit to shuo-wu/longhorn that referenced this issue Jan 28, 2021
Longhorn longhorn#2006

Signed-off-by: Shuo Wu <shuo@rancher.com>
shuo-wu pushed a commit to shuo-wu/longhorn that referenced this issue Jan 28, 2021
Longhorn longhorn#2006

Signed-off-by: Shuo Wu <shuo@rancher.com>
shuo-wu pushed a commit to shuo-wu/longhorn that referenced this issue Feb 2, 2021
Longhorn longhorn#2006

Signed-off-by: Shuo Wu <shuo@rancher.com>
shuo-wu pushed a commit to shuo-wu/longhorn that referenced this issue Feb 2, 2021
Longhorn longhorn#2006

Signed-off-by: Shuo Wu <shuo@rancher.com>
shuo-wu pushed a commit to shuo-wu/longhorn that referenced this issue Feb 25, 2021
Longhorn longhorn#2006

Signed-off-by: Shuo Wu <shuo@rancher.com>
joshimoo pushed a commit that referenced this issue Feb 25, 2021
Longhorn #2006

Signed-off-by: Shuo Wu <shuo@rancher.com>
shuo-wu pushed a commit to shuo-wu/longhorn that referenced this issue Feb 26, 2021
Longhorn longhorn#2006

Signed-off-by: Shuo Wu <shuo@rancher.com>
shuo-wu pushed a commit to shuo-wu/longhorn that referenced this issue Feb 26, 2021
Longhorn longhorn#2006

Signed-off-by: Shuo Wu <shuo@rancher.com>
shuo-wu pushed a commit to shuo-wu/longhorn that referenced this issue Feb 26, 2021
Longhorn longhorn#2006

Signed-off-by: Shuo Wu <shuo@rancher.com>
shuo-wu pushed a commit that referenced this issue Feb 26, 2021
Longhorn #2006

Signed-off-by: Shuo Wu <shuo@rancher.com>
shuo-wu pushed a commit to shuo-wu/longhorn that referenced this issue Mar 8, 2021
Longhorn longhorn#2006

Signed-off-by: Shuo Wu <shuo@rancher.com>
joshimoo pushed a commit that referenced this issue Mar 9, 2021
Longhorn #2006

Signed-off-by: Shuo Wu <shuo@rancher.com>
@yasker
Copy link
Member Author

yasker commented Apr 2, 2021

Move to Icebox. Pending merge of #2295

@innobead
Copy link
Member

innobead commented Apr 7, 2021

The new version of backing image implementation is actually be based on #2295 . To avoid confusing QA for these similar tickets, close this and move focus on #2295.

@innobead innobead closed this as completed Apr 7, 2021
@innobead innobead removed the highlight Important feature/issue to highlight label Apr 9, 2021
scvalex pushed a commit to scvalex/longhorn that referenced this issue May 12, 2021
Longhorn longhorn#2006

Signed-off-by: Shuo Wu <shuo@rancher.com>
scvalex pushed a commit to scvalex/longhorn that referenced this issue May 12, 2021
Longhorn longhorn#2006

Signed-off-by: Shuo Wu <shuo@rancher.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/longhorn-manager Longhorn manager (control plane) kind/feature Feature request, new feature priority/0 Must be fixed in this release (managed by PO) require/auto-e2e-test Require adding/updating auto e2e test cases if they can be automated require/doc Require updating the longhorn.io documentation require/lep Require adding/updating enhancement proposal
Projects
None yet
Development

No branches or pull requests

4 participants