Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stealth not breaking to non-direct dmg spells #2187

Closed
Xadras opened this issue May 24, 2016 · 38 comments
Closed

stealth not breaking to non-direct dmg spells #2187

Xadras opened this issue May 24, 2016 · 38 comments

Comments

@Xadras
Copy link
Collaborator

Xadras commented May 24, 2016

Originally reported by: Anonymous


When you detect a rogue in stealth and cast any kind of offensive spell on them (in this case, apply dots) they should be pulled out of stealth with the application of the dot, not 3seconds later when the dot ticks.


@Xadras
Copy link
Collaborator Author

Xadras commented May 25, 2016

Original comment by Anon X (Bitbucket: Anonx, GitHub: Anonx):


source?

source against this: https://vanilla-twinhead.twinstar.cz/?issue=6264

@Xadras
Copy link
Collaborator Author

Xadras commented May 26, 2016

Original comment by BugReporter5000 (Bitbucket: BugReporter5000, GitHub: Unknown):


I think it is correct blizzard also pulls rogues out of stealth before it does dmg, still does on retail and has done for years at least (whereas rain of fire always had to tick dmg before pulling rogues out of stealth, so that part is incorrect).
edit: nvm blizzard does not seem to pull rogues out of stealth instantly in videos I found - I guess it's one of the things they stealth change on/off through the years.

I will look for proof of dot application pulling rogues out of stealth instantly, I was under the impression that this was common knowledge but I guess not. Stay tuned.

@Xadras
Copy link
Collaborator Author

Xadras commented May 26, 2016

Original comment by BugReporter5000 (Bitbucket: BugReporter5000, GitHub: Unknown):


I believe this stealth bug is linked to this bug: https://bitbucket.org/looking4group_b2tbc/looking4group/issues/1517/drinking-eating-while-getting-damaged-no
The action of applying a dot to someone while they are drinking should make them stop drinking, just like applying a dot should break stealth of a rogue initially, if you detect the rogue.
It's the same logic that is used when a warrior uses Demoralizing Shout to get a rogue out of stealth - it doesn't do dmg but it breaks stealth.

Here is video proof: https://youtu.be/QyTyNaiEJKs?t=610
he uses mind vision to see the rogue even in stealth - then uses shadow word: pain and it instantly breaks the rogue out of stealth on application.

@Xadras
Copy link
Collaborator Author

Xadras commented May 26, 2016

Original comment by Anon X (Bitbucket: Anonx, GitHub: Anonx):


so combat breaks stealth?

@Xadras
Copy link
Collaborator Author

Xadras commented May 27, 2016

Original comment by BugReporter5000 (Bitbucket: BugReporter5000, GitHub: Unknown):


No, not combat - applying a dot to someone in stealth, should break them out of stealth.
Applying a dot should also stand someone up that is eating/drinking. Currently neither happens.

No idea if it's connected, was just a wild guess.

@Xadras
Copy link
Collaborator Author

Xadras commented Jun 27, 2016

Original comment by BugReporter5000 (Bitbucket: BugReporter5000, GitHub: Unknown):


here's another video proving that rogues should get unstealthed when a spell is casted on them. Felhunter uses devour and rogue gets unstealthed: https://youtu.be/7l53X2H8Hz8?t=678

Notice also how the warlock does not get in combat from pet using devour on the rogue (devour puts you in combat on this server).

@Xadras
Copy link
Collaborator Author

Xadras commented Jun 27, 2016

Original comment by Looking4Group (Bitbucket: looking4group_b2tbc, GitHub: Unknown):


What EXACTLY is missing now of these spells? We tried today with warrior shouts for example (both piercing and demo shout) on ptr and it popped rogue out of vanish.

@Xadras
Copy link
Collaborator Author

Xadras commented Jun 27, 2016

Original comment by BugReporter5000 (Bitbucket: BugReporter5000, GitHub: Unknown):


corruption, curse of agony, and siphon life do not unstealth rogues atm, they should.
i'm guessing it's the same with every other dot like shadow word: pain etc.

@Xadras
Copy link
Collaborator Author

Xadras commented Jun 28, 2016

Original comment by Trenchfox (Bitbucket: Trenchfox, GitHub: Trenchfox):


This was fixed and should be live today?

Test it again and let me know I'm 99% sure this was fixed.

@Xadras
Copy link
Collaborator Author

Xadras commented Jun 28, 2016

Original comment by BugReporter5000 (Bitbucket: BugReporter5000, GitHub: Unknown):


just tested again:
curse of exhaustion, curse of elements and curse of weakness all destealth rogue instantly. However curse of exhaustion also destealths the rogue when it runs out, if the rogue casts stealth while it is still up.

Corruption, siphon life and curse of agony still do not destealth a rogue before they deal their first tick of dmg. Devour from felhunter also does not destealth.

For reference I actually found another video: https://youtu.be/2CMLa2enhG4?t=233 - detects both rogue and druid and corruption instantly knocks them out of stealth.

@Xadras
Copy link
Collaborator Author

Xadras commented Jun 28, 2016

Original comment by Anon X (Bitbucket: Anonx, GitHub: Anonx):


Did somebody tryout this from nost: https://bitbucket.org/looking4group_b2tbc/looking4group/issues/1457/combat-from-dots-etc?

@Xadras
Copy link
Collaborator Author

Xadras commented Jun 28, 2016

Original comment by Anon X (Bitbucket: Anonx, GitHub: Anonx):


Issue #1457 was marked as a duplicate of this issue.

@Xadras
Copy link
Collaborator Author

Xadras commented Jul 4, 2016

Original comment by S3kh (Bitbucket: S3kh, GitHub: Unknown):


Be carefull with that report, you are about to add a bug .

Stealth only break when the rogue took a damage ( direct or dot ) and when hit by specific spells like Fear / Psychic Scream / Howl of Terror / Piercing Howl etc . There are a lot of videos where we can see the scrolling combat text show " Consecration " or " Blizzard " poping in the middle of the screen but as long as the rogue move away from this area of effect he will still stay stealthed .

Any video from private servers can't be trusted ! AT is not an exception .

@Xadras
Copy link
Collaborator Author

Xadras commented Jul 4, 2016

Original comment by Delta (Bitbucket: Deltayeah, GitHub: Unknown):


s3kh, please elaborate what u said.

You are saying that rogue shouldn't be out of stealth if hit for example Faerie Fire or Curse of Elements?

I'm playing the rogue, on this server only problem atm is Vile Poisons talent, which is very suspicious and Preparation not resetting some CDs, sometimes vanish,sometimes sprint or evasion.

@Xadras
Copy link
Collaborator Author

Xadras commented Jul 4, 2016

Original comment by S3kh (Bitbucket: S3kh, GitHub: Unknown):


Faerie fire should remove stealth but not the curse of element in your example .

@Xadras
Copy link
Collaborator Author

Xadras commented Jul 4, 2016

Original comment by Delta (Bitbucket: Deltayeah, GitHub: Unknown):


Faerie Fire and Curse of Elements are equal, those are both Marks like, and they increase something on your target.

As far as I know, Curse of elements should remove stealth..Only things that don't remove are distract, earthbind totem and mass dispel ==> TrinityCore/TrinityCore#14819

https://www.youtube.com/watch?v=0xAuRkhnetk 2:20 please.

@Xadras
Copy link
Collaborator Author

Xadras commented Jul 4, 2016

Original comment by S3kh (Bitbucket: S3kh, GitHub: Unknown):


It will only put the warlock in combat not removing rogue's stealth, this macro can be usefull to avoid getting sap that's all . As you can see the rogue is still stealth in the video .

We need retail videos not private server stuff . The best video possible would be a rogue pov in pvp situation .

@Xadras
Copy link
Collaborator Author

Xadras commented Jul 5, 2016

Original comment by Delta (Bitbucket: Deltayeah, GitHub: Unknown):


Don't know really, I just vote for Preparation, yesterday did arena where I did preparation,and 0 CDs got the reset ..
Slice n Dice bug reported yesterday, fixed today.

Preparation reported 1 month ago, not fix so far..

/desperate.

@Xadras
Copy link
Collaborator Author

Xadras commented Jul 5, 2016

Original comment by Trenchfox (Bitbucket: Trenchfox, GitHub: Trenchfox):


Robinsch commented about this on my commit.

I will fix it so every spell other than Mass Dispel, Distract and Earthbind.

@Xadras
Copy link
Collaborator Author

Xadras commented Jul 5, 2016

Original comment by Evolve (Bitbucket: Evolveuwotm9, GitHub: Unknown):


and Mind Soothe and Mind Vision

@Xadras
Copy link
Collaborator Author

Xadras commented Jul 5, 2016

Original comment by S3kh (Bitbucket: S3kh, GitHub: Unknown):


Trenchfox don't fix things without proof ffs ...

All i see here is private server related, we need better proof to avoid adding bugs . Look for example that " curse of elements " this didn't remove stealth . If you are not sure then wait for better clue .

The only dot i know that remove stealth instantly is SW:Pain . Proof : [https://youtu.be/n5XVuHIpucE?t=447](Link URL) at 7:27 he's hit by SW:P and lost his stealth without any damage .

If you have something like this for agony / corruption etc then show it here but stop with private servers video this is not a proof .

As you can see BugReporter5000 was wrong about Blizzard / Consecration / Rain of fire etc :

I think it is correct blizzard also pulls rogues out of stealth before it does dmg, still does on retail and has done for years at least (whereas rain of fire always had to tick dmg before pulling rogues out of stealth, so that part is incorrect).* edit: nvm blizzard does not seem to pull rogues out of stealth instantly in videos I found - I guess it's one of the things they stealth change on/off through the years.**

I will look for proof of dot application pulling rogues out of stealth instantly, I was under the impression that this was common knowledge but I guess not. Stay tuned.

This report is a bit more complicated than just say : " everything that hit the rogue remove his stealth "
*

@Xadras
Copy link
Collaborator Author

Xadras commented Jul 5, 2016

Original comment by Evolve (Bitbucket: Evolveuwotm9, GitHub: Unknown):


its still better than not removing the stealth at all at this moment

@Xadras
Copy link
Collaborator Author

Xadras commented Jul 5, 2016

Original comment by S3kh (Bitbucket: S3kh, GitHub: Unknown):


Adding a bug is better ? Better for who ? Dot will remove the stealth one second later that's not as if the rogue kept his stealth ...

@Xadras
Copy link
Collaborator Author

Xadras commented Jul 5, 2016

Original comment by Evolve (Bitbucket: Evolveuwotm9, GitHub: Unknown):


it is

@Xadras
Copy link
Collaborator Author

Xadras commented Jul 5, 2016

Original comment by S3kh (Bitbucket: S3kh, GitHub: Unknown):


For 1 or 2 second ... keep your good ideas please there are more important bug to fix than this one without proof

@Xadras
Copy link
Collaborator Author

Xadras commented Jul 6, 2016

Original comment by BugReporter5000 (Bitbucket: BugReporter5000, GitHub: Unknown):


The video I linked of the warlock (https://www.youtube.com/watch?v=2CMLa2enhG4&feature=youtu.be&t=233) Is recorded on the Arena Tournament Realm (you know, the tournament realm made for regionals/blizzcon qualification - Not the private server)

@Xadras
Copy link
Collaborator Author

Xadras commented Jul 6, 2016

Original comment by S3kh (Bitbucket: S3kh, GitHub: Unknown):


Ok , then it's a good proof :) .

We can add to the exception list : SW:P, Corruption but that's not a reason to add everything .

@Xadras
Copy link
Collaborator Author

Xadras commented Jul 6, 2016

Original comment by Evolve (Bitbucket: Evolveuwotm9, GitHub: Unknown):


1 or 2 seconds = successful opener u 1490 random nab, instant = lost arena , L2P

@Xadras
Copy link
Collaborator Author

Xadras commented Jul 6, 2016

Original comment by S3kh (Bitbucket: S3kh, GitHub: Unknown):


Try to stay polite ... We're not here to fight but to find what works and what need to be fix, what i say => We need proof to fix things , not inventing something because we think we remember it .

@Xadras
Copy link
Collaborator Author

Xadras commented Jul 8, 2016

Original comment by Trenchfox (Bitbucket: Trenchfox, GitHub: Trenchfox):


@s3kh Curse of elements doesn't take you out of stealth, I never added that.

If you want proof that DoT's would take someone out of stealth, I found this video just for you. https://youtu.be/86ZCLm910uo?t=15m33s Look you can see the rogue loses stealth and then takes damage from the ticket seconds later.

There are some very knowledgeable people out here, and you should trust them if you dont know for yourself, I dont appreciate the accusations.

@Xadras
Copy link
Collaborator Author

Xadras commented Jul 8, 2016

Original comment by S3kh (Bitbucket: S3kh, GitHub: Unknown):


What accusations are you talking about ?

Trenchfox you say :

" I will fix it so every spell other than Mass Dispel, Distract and Earthbind remove stealth " .

Since this is wrong i tell you to search a bit more to avoid scripting a bug, for example " Blizzard " or " Consecration " these spells doesn't remove stealth instantly and it's a known fact .

Some videos show the scrolling combat text from rogues in outdoor pvp, you can see a mage using blizzard and a rogue escaping it without losing his stealth . You have like 1 seconde to go away from the aoe and you're good .

The only problem in what you say is : " so every other spell than " .

There are more than 3 spell that's all . If trying to help is accusation ...

@Xadras
Copy link
Collaborator Author

Xadras commented Jul 8, 2016

Original comment by Evolve (Bitbucket: Evolveuwotm9, GitHub: Unknown):


the blizzard ur talking about has absolutely nothing to do with this bug, blizzard doesnt instantly proc on application WOW WHAT AN INVENTION

@Xadras
Copy link
Collaborator Author

Xadras commented Jul 8, 2016

Original comment by Trenchfox (Bitbucket: Trenchfox, GitHub: Trenchfox):


@s3kh I was quoting a comment made by Robinsch

@Evolveuwotm9 He obviously does not understand the bug, obviously blizzard will not take someone out of combat if it hasnt dealt damage. The only spells that dont cause damage that should remove buffs are DoT's and Faerie Fire. There are perhaps some more but I'm pretty sure that is it.

@Xadras
Copy link
Collaborator Author

Xadras commented Jul 8, 2016

Original comment by S3kh (Bitbucket: S3kh, GitHub: Unknown):


The problem is not if i understand the bug ...

Read what BugReporter5000 say ... He was ( at first ) telling us that Blizzard should instantly remove stealth wich was wrong . That's why i was talking about that .

Then he admit his mistake .

Delta tells me that Curse of Element should remove stealth too . Wich was wrong .

Here come my mistake . I didn't understand you were quoting Robinsch and was afraid you were about to script stealth this way .

For the dot part, i have to admit that to my knowledge only SW:P should remove stealth, that does not mean that i know everything that's why i ask for proof .

PS : Evolve, are you capable to discuss without being a complete douche ?

@Xadras
Copy link
Collaborator Author

Xadras commented Jul 8, 2016

Original comment by Evolve (Bitbucket: Evolveuwotm9, GitHub: Unknown):


no

@Xadras
Copy link
Collaborator Author

Xadras commented Jul 10, 2016

Original comment by vendetta (Bitbucket: vendetta43, GitHub: Unknown):


if it's an AOE spell it will not INSTANTLY take you out. it will wait to dmg you, so if u resist a holy nova im pretty sure it doesnt take you out (could be wrong) however if it's a TARGETED spell then it should instantly take you out. esp if it's a dot,

@Xadras
Copy link
Collaborator Author

Xadras commented Jul 10, 2016

Original comment by BugReporter5000 (Bitbucket: BugReporter5000, GitHub: Unknown):


The only reason aoe spells were even brought up, is because this video was linked of blizzard: https://www.youtube.com/watch?v=DgV-FPWuWQk&feature=youtu.be&t=2m42s

It's one of those things that has changed every now and then with no patch notes, and majority not knowing about it. On retail and for most of MoP, blizzard instantly took rogues out of stealth or stopped someone from drinking before it ticked for dmg. As you can see that was also the case for a period of time in vanilla (unstealth without doing dmg).

Anyways it doesn't matter, because aoe spells are working fine from what I can see - so I don't know why you keep talking about it.

@Xadras
Copy link
Collaborator Author

Xadras commented Aug 30, 2016

Original comment by Anon X (Bitbucket: Anonx, GitHub: Anonx):


.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant