-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adhoc git dependencies over *http* not working #323
Comments
Recently tried this and struggling to get any dependencies not on the default github.com, bitbucket or gitlab extension to work. It doesent help that there doesent seem to be many examples online about pulling dependencies from hosted git and HTTP so the syntax is somewhat unclear so may be my fault but : |
Yes at the moment it is not documented and not available via the cli.
Direct git dependencies are slower to resolve as we need to fetch commits before we can read the manifest. Github/Gitlab/Bitbucket have seperate apis to fetch files for a given commit. |
Issue for supporting this in the CLI: #328 |
Would add the the reason we don't use the Git URL as the name is:
However, this is up for discussion! 🙂 |
This is actually very understandable and helpful, thanks for the responses :) @njlr @nikhedonia , the only concern id raise is that maybe it should be in the documentation outlining usage as its a fairly common use-case to have repo's not on github etc particularly for private companies and may be a decisive factor in choosing a package manager for a cpp project for some people. If you think its worthwhile, I also I dont mind doing it but seems important that if its already available even not via the CLI its worth including a section on just to prevent people moving to other package manager when they otherwise wouldnt. Thanks again for the helpful responses 👍 |
Wiki page added here: https://github.com/LoopPerfect/buckaroo/wiki/Ad-hoc-Dependencies |
Thanks for the update, Much clearer now! I tried to follow those steps but when I add [[location]] in my buckaroo.toml I get parsing errors:
Is this regular or am I doing something incorrect? The buckaroo.toml looks like this:
|
Should be: [[location]]
package = "d2191/Catch" # <---------------- Here
git = "git@localhost:d2191/Catch.git"
[[dependency]]
package = "d2191/Catch"
version = "branch=master" My mistake for copy-pasting without checking. |
I get this issue when trying to pull in repos from a private git that uses a custom port:
Toml file looks like this: [[location]]
package = "protocolbuffers/protobuf"
git = "ssh://git@gitlab.some.host:1234/buckaroo/protobuf.git"
[[dependency]]
package = "protocolbuffers/protobuf"
version = "branch=master" (Also as a side node, I had to fork protobuf because protoc from the supplied repos was crashing unless i changed compilation to cpp11 as protobuf does it in cmake) Edit: |
works fine via ssh
The text was updated successfully, but these errors were encountered: