Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDE 2837: Rename XSemantics to org.eclipse #96

Closed
wants to merge 3 commits into from

Conversation

qtran-n4
Copy link

This PR renames Xsemantics to org.eclipse

@qtran-n4
Copy link
Author

@mmews-n4 Please review. Thanks!

@qtran-n4 qtran-n4 closed this Aug 14, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.835% when pulling 61f5c5c on mmews-n4:IDE-2837 into 374dcf3 on LorenzoBettini:master.

@LorenzoBettini
Copy link
Contributor

Why have you closed the Pr?

@qtran-n4
Copy link
Author

@LorenzoBettini the PR is intended for our fork: mmews-n4#7

@LorenzoBettini
Copy link
Contributor

I don't understand, shouldn't the renaming being applied to this repo?

@mmews-n4
Copy link
Contributor

You're right, but this is just part of our process: Quang made some changes, that are now under review here: mmews-n4#7 . After this review succeeded, we create a second pull request for your repo.

Actually, this second PR for your repo would not be necessary: We could create the zip for the initial Eclipse contribution from our fork. The advantage then would be, that your repo remains with the current name scheme (and not be changed to org.eclipse...). However, we still would like to create a second PR for the renaming, because then we can test that the renaming did not create some new errors. Whether you would like to merge the renaming is up to you.

@qtran-n4 qtran-n4 deleted the IDE-2837 branch August 15, 2017 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants