Add filtering button for test failures #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Losiowaty
approved these changes
Feb 16, 2022
| Button(action: { | ||
| isToggled.toggle() | ||
| }) { | ||
| let imageName = isToggled ? "xmark.octagon.fill" : "xmark.octagon" |
There was a problem hiding this comment.
Nice!
I didn't know you could add "regular" code inside view builders!
| var body: some View { | ||
| List(methods) { method in | ||
| let results = failuresOnly ? methods.filter { $0.result.isSuccess == false } : methods |
There was a problem hiding this comment.
Hmm, this is a little weird 😅
This block of code is a regular "block", right?
How come Swift allows to omit return keyword in multiple statement block? 🤔
Or did they change them to be result builders? (I'm not really super up-to-date with SwiftUI 😅 )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it resolves #4?
The button is added as a bar button item, its state is replicated across both
TestSuitesViewandTestMethodsView.TestSuitesViewTestMethodsViewLet me know if you need anything added/changed here. I tested it manually but it seems like it works, potentially we could add some snapshots with mock results but I didn't want to add another dependency so I'll leave it as is for now.
I can also grab #5 next if you'd like.