Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passport page flipping is slow #1328

Open
Richard-L opened this issue Apr 20, 2024 · 5 comments
Open

Passport page flipping is slow #1328

Richard-L opened this issue Apr 20, 2024 · 5 comments
Labels
Priority: low This may or may not be worked on in the future. TR1X bug A bug with TR1X

Comments

@Richard-L
Copy link
Collaborator

The passport flip animation needs to finish before a new flip input can be registered. Before you could cancel a flip at any time for faster inputs.
The cancelling is possible only after a certain time, about half of the flip animation perhaps, in v3.1.1 and OG. But it's a problem in v4.0.3.
Sadly can't test v4.0 as the download is instantly removed as a virus for me again...

The best solution would be that inputs can be registered immediately, and any animations cancelled accordingly.

@rr-
Copy link
Collaborator

rr- commented Apr 21, 2024

I tried to replicate this but was unsuccessful. The most recent significant change to the passport code occurred between versions 3.0 and 3.1, so I'd expect the last version with a noticeable change to be 3.0, rather than 3.1 as the version 3.1 should be similar to what we see in 4.0.3.

@rr- rr- added TR1X bug A bug with TR1X Priority: low This may or may not be worked on in the future. labels Apr 21, 2024
@walkawayy
Copy link
Collaborator

I tested as far back as 2.13.2, and I don't see any difference in behavior. You can inconsistently flip slightly faster in all versions if the input is timed. But it's not really skipping and it's not that much faster.

The difference in behavior may be related to the slight input lag added from the animation interpolation IMO.

@Richard-L
Copy link
Collaborator Author

That's a good thought. Sorry I didn't test back myself and thanks you did so!

I did feel if it wouldn't just be desirable to make it skipable full stop. I still stumble upon this when navigating the passport. Think it's much nicer without any forced input delay whatsoever here.

@walkawayy
Copy link
Collaborator

@Richard-L how weird is this lol. Rudimentary attempt at removing the delay as a proof of concept.

TR1X No Delay Inv v1.zip

@Richard-L
Copy link
Collaborator Author

@walkawayy It's fantastic, please merge, and thank you so much ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: low This may or may not be worked on in the future. TR1X bug A bug with TR1X
Projects
None yet
Development

No branches or pull requests

3 participants