-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Passport page flipping is slow #1328
Comments
I tried to replicate this but was unsuccessful. The most recent significant change to the passport code occurred between versions 3.0 and 3.1, so I'd expect the last version with a noticeable change to be 3.0, rather than 3.1 as the version 3.1 should be similar to what we see in 4.0.3. |
I tested as far back as 2.13.2, and I don't see any difference in behavior. You can inconsistently flip slightly faster in all versions if the input is timed. But it's not really skipping and it's not that much faster. The difference in behavior may be related to the slight input lag added from the animation interpolation IMO. |
That's a good thought. Sorry I didn't test back myself and thanks you did so! I did feel if it wouldn't just be desirable to make it skipable full stop. I still stumble upon this when navigating the passport. Think it's much nicer without any forced input delay whatsoever here. |
@Richard-L how weird is this lol. Rudimentary attempt at removing the delay as a proof of concept. |
@walkawayy It's fantastic, please merge, and thank you so much ❤️ |
The passport flip animation needs to finish before a new flip input can be registered. Before you could cancel a flip at any time for faster inputs.
The cancelling is possible only after a certain time, about half of the flip animation perhaps, in v3.1.1 and OG. But it's a problem in v4.0.3.
Sadly can't test v4.0 as the download is instantly removed as a virus for me again...
The best solution would be that inputs can be registered immediately, and any animations cancelled accordingly.
The text was updated successfully, but these errors were encountered: