Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look command is ignored if weapons are equipped #1337

Open
Richard-L opened this issue Apr 22, 2024 · 7 comments
Open

Look command is ignored if weapons are equipped #1337

Richard-L opened this issue Apr 22, 2024 · 7 comments
Labels
OG bug A bug in original game Priority: low This may or may not be worked on in the future.

Comments

@Richard-L
Copy link
Collaborator

Richard-L commented Apr 22, 2024

Hard to describe this properly:

  • Stand on ledge
  • Equip weapons
  • Press Look
  • Press foward

Expected: Lara looks.
Instead: She falls down because it now takes the game longer than before to register look is meant to be active.

Walkaway suspected the new targeting functions have to do with it, but turning them off had no effect.

@Richard-L Richard-L changed the title Look command is ignored Look command is ignored if weapons are equipped Apr 22, 2024
@walkawayy
Copy link
Collaborator

walkawayy commented Apr 23, 2024

Ok I finally figured out how to reproduce, and it doesn't matter the options enabled. I'm not if @Richard-L is bringing this up a lot because of some kind of new, different bug, but I found no issues walking if target change is turned off. Turning on the target change option does cause a look delay intentionally, but the issue I am describing is different. It also happens in TombATI. I checked Tomb4, and it does not happen there.

  1. Start running towards a ledge
  2. Hold down walk
  3. Hold down look

@walkawayy walkawayy added the OG bug A bug in original game label Apr 23, 2024
@Richard-L
Copy link
Collaborator Author

Thanks for looking into it. Fwiw, I'm also having issues with walk registering on time. So maybe it's related?

I did try mostly with look, and with weapons equipped, trying to spot an enemy on the ground beneath you, she runs off ledges instead of looking down. Without weapons equipped it seemed to work more as expected.

If you wait a good second or two before pressing a direction, it will work, but I'm fairly sure that's not OG behaviour.

@lahm86
Copy link
Collaborator

lahm86 commented Apr 23, 2024

I believe this is a Windows keyboard binding issue if you are using the defaults for walk and look. Windows interprets Shift + Numpad 0 as Insert and so Shift isn't being passed to the game and Lara runs off the edge. I had similar issues in the remasters (which became more evident because of the loss of dedicated sidestep keys, so sidestepping and looking brought the issue to light for me). As a result, I ended up rebinding my walk key.

Here is a demo with OG key bindings in the first half, and then walk rebound to C rather than Shift in the second half. Look is on Numpad 0 in each case. You can even see NohBoard has issues where the look key becomes stuck if using the defaults (I switch to my TRR layout in the second half, I've yet to update OG layout for C as walk). Pressing walk and then look, you can see the inputs disappear - that's when it changes to Insert. But pressing look first and then walk, it's fine.

https://youtu.be/GNeCv-p9Om0

Once rebound, it doesn't matter the order in which you press walk or look.

I don't know if there is a way to detect Insert in this way and interpret it as walk and look. If it's the same input as the regular Ins key then that could impact people's custom bindings.

@Richard-L
Copy link
Collaborator Author

I appreciate so much how in depth you looked into this 🙏

This looks exactly like my issue, and the end of your video looks exactly how it used to behave.

However, I have walk mapped to the space bar, and look on "C".

Should this matter at all?

@lahm86
Copy link
Collaborator

lahm86 commented Apr 23, 2024

If I change to use those keys, I can't replicate it. Is it perhaps some built-in combination on your specific keyboard language layout?

@Richard-L
Copy link
Collaborator Author

Hmm, I have this one in a QWERTZ layout https://www.corsair.com/de/en/p/keyboards/ch-911d01a-de/k60-pro-tkl-rgb-tenkeyless-optical-mechanical-gaming-keyboardcorsair-opx-switch-de-ch-911d01a-de

Would assume it has no special binds (?). I'm not aware of any.

@rr- rr- added the Priority: low This may or may not be worked on in the future. label Apr 23, 2024
@walkawayy
Copy link
Collaborator

walkawayy commented Apr 23, 2024

Ok I finally figured out how to reproduce, and it doesn't matter the options enabled. I'm not if @Richard-L is bringing this up a lot because of some kind of new, different bug, but I found no issues walking if target change is turned off. Turning on the target change option does cause a look delay intentionally, but the issue I am describing is different. It also happens in TombATI. I checked Tomb4, and it does not happen there.

1. Start running towards a ledge

2. Hold down walk

3. Hold down look

@lahm86 I didn't even know that shift + numpad 0 was an insert shortcut. Insert doesn't work with Num Lock ON. Insert works with Num Lock OFF.

So I tested Num Lock. I found out for the issue I reported, it occurs when Num Lock is ON. Lara does not keep running off the ledge with the combo if Num Lock is OFF.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OG bug A bug in original game Priority: low This may or may not be worked on in the future.
Projects
None yet
Development

No branches or pull requests

4 participants