Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click in TOC doesn't update url in browser #268

Closed
tmo26 opened this issue Nov 16, 2016 · 3 comments
Closed

Click in TOC doesn't update url in browser #268

tmo26 opened this issue Nov 16, 2016 · 3 comments

Comments

@tmo26
Copy link

tmo26 commented Nov 16, 2016

Description

Bug: When clicking on a section in a TOC, the page moves to that section, but the url in the browser doesn't change.

Steps to Reproduce

  1. Goto https://wiki.lede-project.org/faq
  2. In the TOC, click e.g. "Where is the Forum?"

Expected behavior: After clicking "Where is the Forum?", url in browser get's updated to https://wiki.lede-project.org/faq#where_is_the_forum

Actual behavior: After clicking "Where is the Forum?", url in browser stays at https://wiki.lede-project.org/faq

-> Expected and actual behavior are not in line.

  1. In the main page, when you hover over the section title, a link appears to the right of the section title. Click on it.

Expected behavior: After clicking the link, url in browser get's updated to https://wiki.lede-project.org/faq#where_is_the_forum

Actual behavior: After clicking the link, url in browser get's updated to https://wiki.lede-project.org/faq#where_is_the_forum

-> Expected and actual behavior are perfectly in line for these links.

Versions

  • [Bootstrap3 Template] Installed version: 2016-07-05
  • [DokuWiki] 2016-06-26a "Elenor of Tsort"
  • [Browser] FF 50.0 + chrome 54.0.2840.99 m
@bobdeh
Copy link

bobdeh commented Nov 17, 2016

When you disable java script the TOC acts as you expect it. Only the "scroll down animation" will be gone.
So i guess that it results from this animation: the browser does not handle the link like a URL but instead executes the java scripts and scrolls down. Either the animation would have to be removed or in the java script the browser url has to be updated.

@tmo26
Copy link
Author

tmo26 commented Nov 17, 2016

Both solutions would be OK for me.

@polyzen
Copy link
Contributor

polyzen commented Nov 21, 2016

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants