New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

duplicate 'so' property name in bevel-emboss-style #24

Closed

Aidosmf opened this issue Jun 17, 2022 · 3 comments

Member

Aidosmf commented Jun 17, 2022

There is a duplicate property name in "Soften" and "Shadow Opacity".
File: https://github.com/LottieFiles/lottie-docs/blob/main/docs/schema/styles/bevel-emboss-style.json

Aidosmf changed the title ~~The duplicate 'so' property name in bevel-emboss-style~~ duplicate 'so' property name in bevel-emboss-style

Collaborator

mbasaglia commented Jun 30, 2022

Looks like the bodymovin plugin tries to export two properties as so: https://github.com/bodymovin/bodymovin-extension/blob/master/bundle/jsx/utils/layerStylesHelper.jsx#L119-L137

I'll raise an issue with them then fix the schema once I know which one is correct

Collaborator

mbasaglia commented Jun 30, 2022

I made a pull request to rename one of them bodymovin/bodymovin-extension#125

Collaborator

mbasaglia commented Jun 30, 2022

All done

mbasaglia closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment