Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for React 16.8.0+ ? #77

Closed
0x3c opened this issue Mar 15, 2022 · 9 comments
Closed

Support for React 16.8.0+ ? #77

0x3c opened this issue Mar 15, 2022 · 9 comments
Labels

Comments

@0x3c
Copy link

0x3c commented Mar 15, 2022

npm ERR! Found: react@16.14.0
npm ERR! node_modules/react
npm ERR!   react@"^16.13.1" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^17.0.2" from @lottiefiles/react-lottie-player@3.4.2
npm ERR! node_modules/@lottiefiles/react-lottie-player
npm ERR!   @lottiefiles/react-lottie-player@"*" from the root project
@0x3c 0x3c changed the title Support for React 16.8+ ? Support for React 16.8.0+ ? Mar 15, 2022
@samuelOsborne
Copy link
Member

Hi @sosamuel I can't reproduce this error locally or on code sand box. Could you possible share your package.json file ?

https://codesandbox.io/s/flamboyant-shamir-wzjqpq?file=/package.json

@krotovic
Copy link

I may have found similar issue... I have in dependencies react@^17.0.2 and @lottiefiles/react-lottie-player@"^3.4.2 but npm install --no-lockfile crashes with

npm ERR! While resolving: web_v2@6.1.0
npm ERR! Found: @lottiefiles/react-lottie-player@3.1.2
npm ERR! node_modules/@lottiefiles/react-lottie-player
npm ERR!   @lottiefiles/react-lottie-player@"^3.4.2" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! @lottiefiles/react-lottie-player@"^3.4.2" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: react@17.0.2
npm ERR! node_modules/react
npm ERR!   peer react@"^17.0.2" from @lottiefiles/react-lottie-player@3.4.2
npm ERR!   node_modules/@lottiefiles/react-lottie-player
npm ERR!     @lottiefiles/react-lottie-player@"^3.4.2" from the root project
npm ERR! 

I'm not sure whose issue it is, npm or yours.

@RonaldDBezerra
Copy link

hello friend, I have the same problem with my lottie, it doesn't work for version 18.0.0 of react. Does anyone know if there is an update that fixes this?

@YuLingCheng YuLingCheng mentioned this issue May 2, 2022
1 task
@samuelOsborne
Copy link
Member

Hey everyone, please try out version v3.4.5

https://www.npmjs.com/package/@lottiefiles/react-lottie-player/v/3.4.5

@ANIRUDHADITHYA
Copy link

animation loads and display twice in react 18

@samuelOsborne
Copy link
Member

@ANIRUDHADITHYA I can't reproduce this issue

https://codesandbox.io/s/react-18-lottie-player-uegtql

@ANIRUDHADITHYA
Copy link

ANIRUDHADITHYA commented May 4, 2022

@samuelOsborne I have made changes there, kindly check https://codesandbox.io/s/react-18-lottie-player-uegtql

in style using "width=100%" makes the component double

@samuelOsborne
Copy link
Member

@ANIRUDHADITHYA You need to send my the link to your forked codesandbox.

I put width 100% on mine and couldn't reproduce:
https://codesandbox.io/s/react-18-lottie-player-uegtql?file=/src/App.js

@github-actions
Copy link

github-actions bot commented Jul 4, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs.

@github-actions github-actions bot added the stale label Jul 4, 2022
@0x3c 0x3c closed this as completed Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants