Overall Improvments #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make use of semantic HTML - Use proper `next/link` instead of `router.push` - Use SWR for fetching and removed zustand (no need for state management) - Updated DEPS. - Organized import exports - Improved Layout - Use static pages for `pokemon/[name]`, no need to server render as nothing changes. - Improved CSS spacing and shadows - Use `next/image`. - Added preconnect to required origins. - Reduce data passed to page by normalizing Pokémon.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Removed sass
|
Any update on this @Louis3797 ? |
|
Sry was busy for a long time and did not look ^^ but everything looks really great 👍 . Thanks for the contribution |
|
No issues, Glad you liked the PR 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Louis!
Here are some improvements I made, cause I was bored :p
Hope you'll like the pr.
next/linkinstead ofrouter.pushpokemon/[name], no need to server render as nothing changes.next/image.You can inspect it live here.