Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete rewrite #308

Closed
30 tasks done
LouisBarranqueiro opened this issue Nov 13, 2020 · 0 comments
Closed
30 tasks done

Complete rewrite #308

LouisBarranqueiro opened this issue Nov 13, 2020 · 0 comments

Comments

@LouisBarranqueiro
Copy link
Owner

LouisBarranqueiro commented Nov 13, 2020

Changes

  • rewrite in typescript
  • use ts-node
  • use prettier
  • separate webpack configs
  • expose types
  • expose actions creators and state via React hooks (const {notifications, notify, ...actions} = useNotifications())
  • make it functional with only React (with context API, useReducer)
  • make it compatible with redux/mobx
  • new API/helper to define default notifications props
  • new API/helper to customize notifications
  • new API/helper to define the function responsible for generating IDs
  • "overload" notify action creator:
    • notify(notification: Notification)
    • notify(message: string, options: Partial)
    • notify(message: string, status: Status, options: Partial)
  • remove non-customizable behavior (convertStatus, preloadImage, etc…)
  • remove redux-thunk dependency
  • rewrite with functional components
  • extract animations from themes and make them customizable via the main package
  • new inline CSS styling API
  • new classnames to update theme
  • new API to customize components (Notification, NotificationIcon, Transition)
  • only support the latest version of react
  • make resize behaviors/options customizable
  • rename closeButton attribute to showCloseButton attribute
  • replace icon librairies dependencies with in-house svg
  • add new boostrap theme
  • add new atalho theme
  • add grow and fade transition
  • align icon and close icon and message
  • include bootstrap with npm for the demo
  • replace enzyme with react testing library
  • replace coveralls with codecov
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant