Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work in IE 11 #2

Closed
jacobg opened this issue Feb 15, 2019 · 4 comments
Closed

Doesn't work in IE 11 #2

jacobg opened this issue Feb 15, 2019 · 4 comments

Comments

@jacobg
Copy link

jacobg commented Feb 15, 2019

If you go to https://louismazel.github.io/vue-phone-number-input/, the page doesn't render, and you'll see this error:
Multiple definitions of a property not allowed in strict mode

The error is in the component itself, because my own app using this component also has the error.

@jacobg
Copy link
Author

jacobg commented Feb 15, 2019

The problem is that in the umd dist file on line 1901, there is a duplicated is-focused attribute:

var render = function () {var _vm=this;var _h=_vm.$createElement;var _c=_vm._self._c||_h;return _c('div',{ref:"parent",staticClass:"field",class:[{
    'is-focused': _vm.isFocus,
    'has-value': _vm.value,
    'has-error': _vm.error,
    'is-disabled': _vm.disabled,
    'is-dark': _vm.dark,
    'is-focused': _vm.valid,
    'has-hint': _vm.hint && !_vm.value
  }, _vm.size],...

I don't know why though, because the source code doesn't have that:

  <div
    ref="parent"
    v-click-outside="onBlur"
    :class="[{
      'is-focused': isFocus,
      'has-value': value,
      'has-hint': hint,
      'has-error': error,
      'is-disabled': disabled,
      'is-dark': dark,
      'no-flags': noFlags
    }, size]"
    class="field country-selector"
    @click="onFocus"
    @keydown="keyboardNav"
  >

Any ideas?

@jacobg
Copy link
Author

jacobg commented Feb 18, 2019

I just saw the issue is in your vue-input-ui project:
LouisMazel/vue-input-ui#1

@LouisMazel
Copy link
Owner

It's fixed here too !
Let me know if all is good

Thanks again :)

@jacobg
Copy link
Author

jacobg commented Feb 18, 2019

Thanks! Much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants