Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi language support #13

Merged
merged 9 commits into from
Jun 19, 2018
Merged

Multi language support #13

merged 9 commits into from
Jun 19, 2018

Conversation

simon300000
Copy link
Contributor

@simon300000 simon300000 commented Jun 16, 2018 •
edited

Use react-intl for multi language support

ps: did not actually do any translation

@simon300000 simon300000 changed the title Add translation ability Multi language support Jun 16, 2018
@coveralls
Copy link

coveralls commented Jun 16, 2018 •
edited

Coverage Status

Coverage increased (+0.01%) to 35.206% when pulling a08f40e on simon300000:1.x-dev into ad342af on LoveLiveSunshine:1.x-dev.

@kokororin
Copy link
Owner

  • There is no issue with rhl. Use yarn instead of npm.
  • Indentations are not correct

@simon300000
Copy link
Contributor Author

simon300000 commented Jun 17, 2018 •
edited

I see no warning about indentations but I tried to fix it.

By the way, should I pull request to master branch or this 1.x-dev?@kokororin

@kokororin kokororin merged commit 5873964 into kokororin:1.x-dev Jun 19, 2018
@kokororin
Copy link
Owner

1.x-dev is right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@simon300000 @coveralls @kokororin