Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.2.3 shows 3rd party prompt even when disabled #1149

Closed
flrgh opened this issue May 16, 2022 · 3 comments
Closed

3.2.3 shows 3rd party prompt even when disabled #1149

flrgh opened this issue May 16, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@flrgh
Copy link
Contributor

flrgh commented May 16, 2022

馃憢 I just updated from 3.2.2 => 3.2.3. The language server now asks the client (neovim in my case) if I want to configure the workspace for OpenResty, every time.

RPC log snippet from my editor:

[DEBUG][2022-05-16 13:15:22] .../vim/lsp/rpc.lua:454	"rpc.receive"	{
  jsonrpc = "2.0",
  method = "window/logMessage",
  params = {
    message = "Do you need to configure your work environment as `OpenResty`?",
    type = 3
  }
}
[DEBUG][2022-05-16 13:15:22] .../vim/lsp/rpc.lua:454	"rpc.receive"	{
  id = 3,
  jsonrpc = "2.0",
  method = "window/showMessageRequest",
  params = {
    actions = { {
        title = "Apply and modify settings"
      }, {
        title = "Apply but do not modify settings"
      }, {
        title = "Don't show again"
      } },
    message = "Do you need to configure your work environment as `OpenResty`?",
    type = 3
  }
}

My config has workspace.checkThirdParty set to false.

Reverting back to 3.2.2 resolves the issue for me.

This gist contains more complete RPC logs for 3.2.3 and 3.2.2.

Environment

  • OS: Linux x86_64 (Fedora 35)
  • Is WSL remote? N/A
  • Client: neovim 0.7
@chadvandy
Copy link

Same here - this issue also occurs after pressing "Don't show again" or already having the workspace "user third party" set to the environment the plugin is reading.

@sumneko sumneko added the bug Something isn't working label May 24, 2022
@sumneko
Copy link
Collaborator

sumneko commented May 24, 2022

Could you please provide the logs from server side?
Find logs: https://github.com/sumneko/lua-language-server/wiki/Default-log-path

Add "--loglevel=trace" to your command line

@sumneko sumneko added the Info Needed More information is required label May 24, 2022
@flrgh
Copy link
Contributor Author

flrgh commented May 24, 2022

@sumneko sure thing, here are more complete logs:

https://gist.github.com/flrgh/3c66a895e93896383af279e9962f28b3

@sumneko sumneko removed the Info Needed More information is required label May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants