unnecessary newline added when format on paste is enabled

[xiangnanscu]

How are you using the lua-language-server?

Visual Studio Code Extension (sumneko.lua)

Which OS are you using?

Windows WSL

What is the issue affecting?

Formatting

Expected Behaviour

When I refine my code I usually need to copy and paste some code in an inserting style. In this case, could the ext check if there is a line in the next position so doesn't add newline? format on paste is a useful option, I don't want to turn it off.

local function foo()
  -- try to paste 'local a= 1' here
  local b = 2
end

expected:

local function foo()
  local a = 1
  local b = 2
end

Actual Behaviour

local function foo()
  local a = 1

  local b = 2
end

Reproduction steps

just as above

Additional Notes

No response

Log File

No response

[carsakiller]

Formatting is provided by https://github.com/CppCXY/EmmyLuaCodeStyle, this may be an issue with that project.

[ltWolfik]

Seems, the problem originates from config insert_final_newline option. When a line is formatted - the EmmyLuaCodeStyle adds newline because of insert_final_newline = true

The same problem when Format selection is used. Possible workaround - to disable insert_final_newline for lua in editorconfig. But the perfect solution would be ignore insert_final_newline when doing Format selection or on pasting.

[CppCXY]

Seems, the problem originates from config insert_final_newline option. When a line is formatted - the EmmyLuaCodeStyle adds newline because of insert_final_newline = true

The same problem when Format selection is used. Possible workaround - to disable insert_final_newline for lua in editorconfig. But the perfect solution would be ignore insert_final_newline when doing Format selection or on pasting.

that's not my problem，this is a bug, but It is currently a holiday, and after the holidays the author will fix that.