Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Since todays update it keeps forcing Lua 5.4 even after I've manually changed it to 5.1. #1864

Closed
ZoeESummers opened this issue Jan 31, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@ZoeESummers
Copy link

How are you using the lua-language-server?

Visual Studio Code Extension (sumneko.lua)

Which OS are you using?

Windows

What is the issue affecting?

Diagnostics/Syntax Checking

Expected Behaviour

I set it to 5.1.

It stays locked to lua 5.1

Actual Behaviour

I set it to 5.1.

I go to my code, it parses it and flags up lots of deprecated functions,

I check the settings.json and it's back to 5.4.

Reproduction steps

I have lots of lua 5.1 code.

I updated to todays (31/1/23) version.

When I click on a lua file, it parses it, and shows lots of errors of deprecated functions - because the settings.json is now lua 5.4 -> but i never changed it to 5.4 It's doing it every time I open a file.

Additional Notes

No response

Log File

No response

@carsakiller
Copy link
Collaborator

Possibly due to what looks like some unfinished code

@carsakiller carsakiller added the bug Something isn't working label Feb 1, 2023
@bandaloo
Copy link

bandaloo commented Feb 1, 2023

yes! same thing keeps happening to me. i was about to open an issue but you beat me to it by less than an hour. constantly see this diff when i'm staging stuff, and i can't figure out what triggers it:

diff --git a/.vscode/settings.json b/.vscode/settings.json
index 688a1cc..26da040 100644
--- a/.vscode/settings.json
+++ b/.vscode/settings.json
@@ -1,3 +1,3 @@
 {
-  "Lua.runtime.version": "LuaJIT"
+  "Lua.runtime.version": "Lua 5.4"
 }
(END)

@sumneko
Copy link
Collaborator

sumneko commented Feb 1, 2023

My bad, fixed by LuaLS/vscode-lua@8c81892

@ZoeESummers
Copy link
Author

thank you @sumneko - do you know when this will be pushed into release?

@sumneko
Copy link
Collaborator

sumneko commented Feb 1, 2023

thank you @sumneko - do you know when this will be pushed into release?

In 24 hours, I'm waiting for some other bug resolving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants