Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

freebsd 13.2 can not compile ,, it bugs #2361

Open
jiadsii opened this issue Oct 8, 2023 · 6 comments
Open

freebsd 13.2 can not compile ,, it bugs #2361

jiadsii opened this issue Oct 8, 2023 · 6 comments

Comments

@jiadsii
Copy link

jiadsii commented Oct 8, 2023

How are you using the lua-language-server?

Other

Which OS are you using?

Other

What is the issue affecting?

Other

Expected Behaviour

when i try to compile this in freebsd, it cannot coplete in once, and it reports error

Actual Behaviour

i think it never compile in freebsd 13.2

and i hope it can add a package for freebsd

Reproduction steps

i just do according to the document.

Additional Notes

No response

Log File

No response

@nospam2998
Copy link

Does it work better on FreeBSD 14.0-RELEASE? What are the exact commands run and the error message encountered?

@brianreichtcs
Copy link

I am also on FreeBSD 13.2. Here's my output from make.sh, if that helps.

output.txt

@nospam2998
Copy link

Thanks @brianreichtcs for logs and steps to reproduce. I get similar results with FreeBSD 14.0-RELEASE.

At least some of the errors seems to be from bee.lua, which is a submodule of lua-language-server. A brief look at the source code indicates that the BSD code merely points at the linux implementation. Without properly reading nor understand the details, I see mentions of inotify which natively is a linux specific API. An interesting quote from bee.lua#42 reads:

filewatch on freebsd is incomplete. filewatch depends on libinotify-kqueue, but unfortunately libinotify-kqueue doesn't work correctly.

Furthermore bee.lua#12 states that lua-language-server is unlikely to use filewatch, so the failing tests should be safe to ignore.

As far as I know, lua-language-server does not use filewatch, you can ignore this test.

Maybe it is possible add conditionals around irrelevant functionality and their tests? Either in bee.lua, lua-language-server or in the ports tree. I will unfortunately not be able to attempt that anytime soon though.

@brianreichtcs
Copy link

brianreichtcs commented Mar 12, 2024

Fair enough :) I'm trying to work my team out of the FreeBSD business for exactly reasons like this. I thought given some more information maybe there'd be an existing solution, but didn't expect anyone to spend time on this to solve the issue for the 6 people it will impact. Thanks for looking it over, and thanks for all your efforts! Looking forward to using this package when we port over to Linux.

@vermaden
Copy link

These instructions seem to work on my FreeBSD 14.0 system - I needed to 'silence' two tests ...

# pkg install ninja

% git clone https://github.com/LuaLS/lua-language-server.git

% cd lua-language-server

% :> 3rd/bee.lua/test/test.lua

% :> test.lua

% ./make.sh

% ./bin/lua-language-server
Content-Length: 120

{"jsonrpc":"2.0","method":"$/status/report","params":{"text":"Lua","tooltip":"Cached files: 0/0\nMemory usage: 2M"}}

@brianreichtcs
Copy link

These instructions seem to work on my FreeBSD 14.0 system - I needed to 'silence' two tests ...

# pkg install ninja

% git clone https://github.com/LuaLS/lua-language-server.git

% cd lua-language-server

% :> 3rd/bee.lua/test/test.lua

% :> test.lua

% ./make.sh

% ./bin/lua-language-server
Content-Length: 120

{"jsonrpc":"2.0","method":"$/status/report","params":{"text":"Lua","tooltip":"Cached files: 0/0\nMemory usage: 2M"}}

Skipping the tests as you demonstrated makes the build succeed. Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants