Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin crash after you add a folder to workspace #520

Closed
rdelian opened this issue Apr 26, 2021 · 4 comments
Closed

Plugin crash after you add a folder to workspace #520

rdelian opened this issue Apr 26, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@rdelian
Copy link

rdelian commented Apr 26, 2021

Describe the bug
Plugin crash after you add a folder to workspace

To Reproduce
Steps to reproduce the behavior:

  1. Go to File > Add Folder To Workspace...
  2. Select any folder, even an empty one will do the job

Expected behavior
"Normal stuff"

Screenshots

No workspace, all good

image

After you add a folder in editor

image

Environment (please complete the following information):

  • OS: Windows
  • Is WSL remote? -> No
  • Client: VSCode

Additional context
If you make a new file inside the folder you've added, the extension will work again

Provide logs
https://pastebin.com/raw/GGpSrzt7

@rdelian
Copy link
Author

rdelian commented Apr 26, 2021

It also doesn't work on my project which has 50+ files

image

Here's the log for ^
https://pastebin.com/raw/vZkxVDza

@sumneko sumneko added the bug Something isn't working label Apr 28, 2021
@sumneko
Copy link
Collaborator

sumneko commented Apr 29, 2021

Due to the current design and implementation, only the following situations are supported:

  1. Open any number of files without opening any workspace
  2. When one or more workspaces are opened, only files in these workspaces are supported

I have decided to replace this design, but there is no time to implement it yet, so you need to wait for a while.

@rdelian
Copy link
Author

rdelian commented Apr 29, 2021

I understand, but not even 2 works for me.
As you can see in my second post the file common.lua it's from the workspace

EDIT: It's related to #522

@sumneko
Copy link
Collaborator

sumneko commented May 7, 2021

Should be fixed.

@sumneko sumneko closed this as completed May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants