Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lua-language-server not feature testing for LocationLink support for Goto Definition #612

Closed
sm2n opened this issue Jul 21, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@sm2n
Copy link

sm2n commented Jul 21, 2021

The LSP specification says that LocationLink[] support should depend on the client capability textDocument.definition.linkSupport, but the server doesn't appear to actually do this.

This issue came up recently with eglot, a client for emacs, here: joaotavora/eglot#711
There is an example in the linked issue. The version of lua-language-server used there is 2.3.1.

@sumneko
Copy link
Collaborator

sumneko commented Jul 21, 2021

This extension was originally designed for VSCode, so I only guarantee its compatibility with VSCode.
For most of the functions, I did not check whether the client provides this capability, but simply assumed that it does.
Because it takes too much time and energy to check every capability and correctly handle the behavior when the capability is missing, especially for individual developers like me.

However, as more and more language clients appeared, I also added many compatibility measures based on feedback. If you find a new compatibility issue in the future, you are welcome to continue to give feedback and I will try my best to solve it.

@sumneko sumneko added the bug Something isn't working label Jul 21, 2021
@sm2n
Copy link
Author

sm2n commented Jul 21, 2021

Sounds quite reasonable. That said, I would expect to see more non-vscode usage (and possibly bug reports) in the future as this server seems to have become the de facto default language server for lua, and is increasing in exposure. For example, it was added to the arch linux [community] repository last week.

By the way, thank you very much for creating lua-language-server. My experience using lua has been much better since I started using it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants