fix(toDash): Add missing transfer characteristics for h264 streams #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YouTube doesn't provide any color information for the h264 streams in their API responses. Players like shaka-player treat streams with missing color information differently, so you end up with duplicate qualities in the quality selector. As the h264 files that YouTube offers always seem to be SDR, it's a pretty safe bet to hard code that into the DASH manifest generator.
Alternatively we could copy the color information from the
vp9(not thevp9.2) streams, but we would have to do that before we apply the users format filter, it would also mean that it would only work ifvp9formats exist and are passed in.