error: too few arguments to function 'rmt_wait_tx_done'

[jaimeyu]

Hey project cannot compile b/c of bad rmt call.

IDF SDK v2.1.1 and cloned the repo commit 91bfc04 on Oct 4

/home/esp32/Projects/ESP32/libraries/ESP32_LED_STRIP/components/led_strip/./led_strip.c: In function 'led_strip_task':
/home/esp32/Projects/ESP32/libraries/ESP32_LED_STRIP/components/led_strip/./led_strip.c:239:9: error: too few arguments to function 'rmt_wait_tx_done'
rmt_wait_tx_done(led_strip->rmt_channel);
^
In file included from /home/esp32/Projects/ESP32/libraries/ESP32_LED_STRIP/components/led_strip/inc/led_strip/led_strip.h:18:0,
from /home/esp32/Projects/ESP32/libraries/ESP32_LED_STRIP/components/led_strip/./led_strip.c:18:
/home/esp32/esp/esp-idf/components/driver/include/driver/rmt.h:688:11: note: declared here
esp_err_t rmt_wait_tx_done(rmt_channel_t channel, TickType_t wait_time);
^
/home/esp32/esp/esp-idf/make/component_wrapper.mk:242: recipe for target 'led_strip.o' failed
make[1]: *** [led_strip.o] Error 1
/home/esp32/esp/esp-idf/make/project.mk:435: recipe for target 'component-led_strip-build' failed
make: *** [component-led_strip-build] Error 2

[steadfastnz]

rmt_wait_tx_done now has a second parameter - a timeout. I've used portMAX_DELAY so line 250 of led_strip.c now reads
rmt_wait_tx_done(led_strip->rmt_channel,portMAX_DELAY);

[Mrunmoy]

After fixing the above, I get

/home/sam/projects/ESP32_LED_STRIP/build/main/libmain.a(main.o):(.literal.app_main+0x4): undefined reference to `main_led_task'
collect2: error: ld returned 1 exit status
/home/sam/esp/esp-idf/make/project.mk:405: recipe for target '/home/sam/projects/ESP32_LED_STRIP/build/led_strip.elf' failed

[Mrunmoy]

All I have to do is read your readme and create a main thread lol
Cheers!