Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved lastfm #8

Merged
merged 1 commit into from Aug 30, 2022
Merged

improved lastfm #8

merged 1 commit into from Aug 30, 2022

Conversation

Tetrax-10
Copy link
Contributor

  1. Never declare variables in global scope it creates issues with other extension like Sort by Play Count extension ( I thought my extension is working fine but its working fine because of your global variable. Then I fixed it)
  2. If user need to change the username then the placeholder will be the old username
  3. diff themes will have diff button color if you don't use any theme it will be green (default) :
    image

@Taeko-ar
Copy link
Owner

Thanks for the fixes :)

@Taeko-ar Taeko-ar merged commit 088bc45 into Taeko-ar:main Aug 30, 2022
@Tetrax-10 Tetrax-10 deleted the patch-1 branch August 31, 2022 05:22
@Tetrax-10
Copy link
Contributor Author

Thanks for the fixes :)

always glad to help, Also I used your popup modal in Sort by Play Count. It lit saved my time thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants