Network e Repository(Paging) layers implementados. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lhmsouza
requested changes
May 21, 2021
app/src/main/java/com/lucascabral/marvelsuperheroes/helper/ConstantKeys.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/lucascabral/marvelsuperheroes/presenter/di/NetworkModule.kt
Show resolved
Hide resolved
app/src/main/java/com/lucascabral/marvelsuperheroes/presenter/view/AllCharactersActivity.kt
Outdated
Show resolved
Hide resolved
...rc/main/java/com/lucascabral/marvelsuperheroes/presenter/viewmodel/AllCharactersViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/lucascabral/marvelsuperheroes/presenter/di/NetworkModule.kt
Show resolved
Hide resolved
added 3 commits
May 21, 2021 09:24
…ite. Todos os testes de modulos do koin passaram. Criado o companion object para evitar magic numbers.
Lhmsouza
approved these changes
May 21, 2021
Lhmsouza
reviewed
May 21, 2021
|
|
||
| val viewModelModule = module { | ||
|
|
||
| single { AllCharactersViewModel() } |
There was a problem hiding this comment.
Aqui poderia usar viewModel { AllCharactersViewModel() }, mas acredito que com um single funcione também.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Foi criado:
a camada de network em um modulo usando koin.
a classe de paginação (usando a biblioteca paging3), que esta sendo utilizada no viewModel dentro da função getListData. A activity através desta função observará as mudanças de paginação e notificará o Adapter.
OBS: Futuramente penso em fazer algumas modificações para deixar o código escalável e melhor testável. A classe criada para fazer a paginação não trabalha como um repositório em si. Como estou usando o paging3 pela primeira vez, resolvi fazer primeiro dessa maneira. Também penso em fazer cache das páginas usando room.
Após fazer essa modificações, consigo trabalhar melhor com o koin e criar os modulos para o repository e viewModel.
Link trello:
https://trello.com/c/XrDUhcKv/49-projeto-final-marvel-cria%C3%A7%C3%A3o-da-camada-de-repository-do-projeto