Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setCookie documentation is wrong #79

Open
uuksu opened this issue Oct 11, 2017 · 0 comments
Open

setCookie documentation is wrong #79

uuksu opened this issue Oct 11, 2017 · 0 comments

Comments

@uuksu
Copy link

uuksu commented Oct 11, 2017

setCookie documentation in README.md says:

Parameters

  • name string The name of the cookie.
  • value string The value of the cookie.
  • options (optional, default {})
  • url string The request-URI to associate with the setting of the cookie.

So this should work:
await mainTab.setCookie("cookie", "1", {}, "http://example.com")

It does not. Right syntax seems to be:
await mainTab.setCookie("cookie", "1", {url: "http://example.com"})

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant