New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove use of innerHTML repalce with createElement? React 15 #42
Comments
React-lite always use createElement, never use innerHTML to create real dom, but use to clear current childNodes of container dom. |
Why not use reacts way to cleanup the children of container dom? Just a simple while loop. Faster too |
The first, you are wrong about the way react-lite handle vdom to real-dom The second, you should show me the perf-test to prove what you said, and had better fork react-lite and pull request to me. Talk is cheap! |
That is good, hope next time you open issue will show the evidences directly ; ) Will resolve it soon. |
And next time I hope authors of repos I visit at least have basic knowledge about things |
Come on, if Additionally, use innerHTML to clear container is not commonly usedery in react-lite, The improve of changing innerHTML to removeChild is very limited . This issue even not worth mentioning. |
React 15 removed use of innerHTML and now uses createElement. See latest release notes.
You are still using innerHTML - wich is slow - a lot.
Are you going to fix this?
The text was updated successfully, but these errors were encountered: