Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve get_uuid and get_uuids #21

Merged
merged 7 commits into from
Jan 31, 2022
Merged

Improve get_uuid and get_uuids #21

merged 7 commits into from
Jan 31, 2022

Conversation

Lucino772
Copy link
Owner

@Lucino772 Lucino772 commented Jan 31, 2022

  • get_uuid returns a string
  • get_uuids returns a dict of string and string
  • Fix tests for get_uuid & get_uuids
  • Remove UUIDInfo class
  • Update V2 Roadmap in README

@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2022

Codecov Report

Merging #21 (d4fe392) into main (3ce234a) will decrease coverage by 0.50%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
- Coverage   46.68%   46.17%   -0.51%     
==========================================
  Files          29       29              
  Lines         951      942       -9     
  Branches      125      123       -2     
==========================================
- Hits          444      435       -9     
  Misses        493      493              
  Partials       14       14              
Impacted Files Coverage Δ
mojang/api/structures/base.py 53.57% <ø> (-7.04%) ⬇️
mojang/api/base.py 94.91% <100.00%> (-0.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ce234a...d4fe392. Read the comment docs.

@Lucino772 Lucino772 merged commit ba141f5 into main Jan 31, 2022
@Lucino772 Lucino772 deleted the v2/improve-get-uuid branch January 31, 2022 00:29
@Lucino772 Lucino772 added the enhancement New feature or request label Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants