Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(get_names): removed username history API #46

Merged
merged 3 commits into from
Oct 25, 2022
Merged

Conversation

Lucino772
Copy link
Owner

@Lucino772 Lucino772 commented Oct 25, 2022

Description

The username history API has been removed. For more info, check out this link.

Type of change

  • ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Base: 68.36% // Head: 67.92% // Decreases project coverage by -0.43% ⚠️

Coverage data is based on head (8c0f4d0) compared to base (9c9fc1f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
- Coverage   68.36%   67.92%   -0.44%     
==========================================
  Files          27       27              
  Lines         923      901      -22     
  Branches      122       83      -39     
==========================================
- Hits          631      612      -19     
+ Misses        272      269       -3     
  Partials       20       20              
Impacted Files Coverage Δ
mojang/__init__.py 100.00% <ø> (ø)
mojang/api/__init__.py 100.00% <ø> (ø)
mojang/api/session.py 98.78% <ø> (-0.02%) ⬇️
mojang/api/structures.py 100.00% <ø> (ø)
mojang/api/urls.py 100.00% <ø> (ø)
mojang/api/auth/models.py 41.13% <100.00%> (+0.03%) ⬆️
mojang/api/base.py 98.21% <100.00%> (-0.36%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Lucino772 Lucino772 merged commit 4bebf53 into main Oct 25, 2022
@Lucino772 Lucino772 deleted the removal/name-history branch October 25, 2022 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant