Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue with the status code for get_uuid & get_username #61

Merged
merged 3 commits into from
Feb 8, 2023

Conversation

Lucino772
Copy link
Owner

@Lucino772 Lucino772 commented Feb 8, 2023

Description

This PR fixes some issues with the status code returned by the APIs for the get_uuid and get_username functions. Instead of returning 404 when value does not exists, the APIs returns 204.

Type of change

  • 🪳 Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes

@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Base: 67.96% // Head: 67.96% // No change to project coverage 👍

Coverage data is based on head (61f51da) compared to base (efede91).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 61f51da differs from pull request most recent head 426d621. Consider uploading reports for the commit 426d621 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #61   +/-   ##
=======================================
  Coverage   67.96%   67.96%           
=======================================
  Files          27       27           
  Lines         902      902           
  Branches       83       83           
=======================================
  Hits          613      613           
  Misses        269      269           
  Partials       20       20           
Impacted Files Coverage Δ
mojang/api/base.py 98.21% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Lucino772 Lucino772 merged commit 87bb839 into main Feb 8, 2023
@Lucino772 Lucino772 deleted the hotfix/get-uuid-and-username branch February 8, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant