Unnecessary space added if line contains comment char only

[savchenko]

:set ft=bash and add execute :CBllline on an empty commented line.

Before

  #

After

# ──  ─────────────────────────────────────────────────────────────────────────────

[LudoPinelli]

Yes, it's because :CBllline is for a titled line (first "l" for the alignement of the line, second "l" for the alignement of the text, then "line", so 3 "l"), it expects that there is a string to align left on the line where the space is.

For a simple full line, the command is :CBlline (just 2 "l").

I agree that it's not very intuitive. I will add a check in case there is no text to avoid this behavior, thanks!

[savchenko]

I agree that it's not very intuitive. I will add a check in case there is no text to avoid this behavior, thanks!

Might be worthwhile to merge those two under one function.

if line_contains_text then
    execute CommentWithSpace
else
    execute CommentSimpleLine

[LudoPinelli]

Yes. It's not only the space btw, it's also the symbols before and after the text that are put no matter a text is on the line or not (it didn't show in your example because the symbols before and after the text are set to the same symbol as the one for the line by default).
For example :CBllline10 without text gives:

# ├┤  ├──────────────────────────────────────────────────────────────────┤

I'm currently rewriting the plugin from the ground up for the next version, in part because of this kind of poor design choices. The "simple lines" and "titled lines" won't be treated as two different categories.
But it will take some time, I will make a patch for the current version.

[LudoPinelli]

Done!

[savchenko]

I'm currently rewriting the plugin from the ground up for the next version

Do you plan to land #36 there or as a patch for the current master?

[LudoPinelli]

It will be for the the rewritten version, it needs too many changes to be patch for the current one. It's going quite well so far, but I honestly don't know when it will be available.

[savchenko]

Updated to latest, executing on this line:

        config = function()

CBllline<cr>

Note the offset and spaces.

-- -- config = function() --------------------------------------------------------

:CBlline<cr>

-- -------------------------------------------------------------------------------

[LudoPinelli]

Sorry, I don't understand what the problem is in your example?

[savchenko]

I would expect that from this:

        config = function()

comment-box returns either:

-- ---- config = function() ---------------------------------------------------

or

--      config = function() ---------------------------------------------------

Note the preserved column position.