Skip to content
This repository has been archived by the owner on Jul 24, 2023. It is now read-only.

Add music from other Ace Attorney games #19

Closed
jonatep opened this issue Mar 9, 2021 · 3 comments · Fixed by #20
Closed

Add music from other Ace Attorney games #19

jonatep opened this issue Mar 9, 2021 · 3 comments · Fixed by #20
Labels
enhancement New feature or request

Comments

@jonatep
Copy link
Contributor

jonatep commented Mar 9, 2021

I think it would be cool to add the trial and pursuit music from Justice for All and/or Trials and Tribulations, so it is selected randomly every time the bot is called, or it is specified as an argument in the mention. For example, if you want the music to be from Justice for All, you must mention the bot like this: "@aceCourtbot render, music=JFA"

@jonatep
Copy link
Contributor Author

jonatep commented Mar 9, 2021

I just realized I should have opened this issue here https://github.com/LuisMayo/ace-attorney-bot/tree/b16d85b079dafe3d291a539a57a1763a749d5969, as that's the part involved with the video rendering. Sorry for the mistake

@LuisMayo
Copy link
Owner

LuisMayo commented Mar 9, 2021

Don't worry, both issues need to be created as both the rendering engine needs to support the option and the twitter bot needs to parse the command.

And thanks a lot for the suggestion, I find this one particularly interesting and shouldn't be hard to implement.
Thanks a lot!

@LuisMayo
Copy link
Owner

LuisMayo commented Mar 9, 2021

Depends on LuisMayo/objection_engine#26

@LuisMayo LuisMayo linked a pull request Mar 16, 2021 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants