Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve room code ergonomics #7

Closed
LukeChannings opened this issue Dec 10, 2020 · 4 comments
Closed

Improve room code ergonomics #7

LukeChannings opened this issue Dec 10, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@LukeChannings
Copy link
Owner

It's hard to share the code, and there are situations when a room code isn't really needed at all.

  • add an option to disable room codes
  • implement a share sheet for the room code to make it easier to share
@pconwell
Copy link

pconwell commented Jan 6, 2021

I also posted in #4, and I think this might be a similar request here.

I'd like a way to send a link to a specific room. For example, I send my wife a text with a link to http://192.168.1.94:8000/XXXX and she can just click the link and type in her name. Or even better may be an option to send a link like http://192.168.1.94:8000/XXXX#wife or http://192.168.1.94:8000/XXXX?user=wife or whatever the proper formatting would be. Obviously, this would create a bit more work on my end, but I think reducing friction for certain users would make life a lot easier in the long run.

@LukeChannings
Copy link
Owner Author

Hey Patrick,

The current version does not support deep linking to a room code.

I'm working on a new version that includes both deep linking and sharing.

It will look something like this:

Screenshot 2021-01-06 at 23 07 53

@pconwell
Copy link

Sorry for the late reply, work has been busy. This looks great! Thank you

@LukeChannings
Copy link
Owner Author

This is fixed in 2.0.0-alpha.1, with the caveat that:

  1. Tapping the share icon will copy the current URL (with a roomName=<roomName> query parameter)
  2. Sharing will not work for non-HTTPS websites on iOS (I will add a message about this)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants