Add additional builder for cookie settings #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not fond of exposing knobs to weaken the security posture - looking at |
|
Thanks for the feedback. Fixed. Now only path and domain are settable. |
|
Thanks for checking that. How about this? Domain should now remain unset if it is not set by the user. |
|
Thanks! Yes, much better this way! |
jeremymarch
commented
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'm proposing to add builder options for the rest of the cookie settings in CookieMessageStore. It's useful to be able to set these, for example when testing without https, etc. Please let me know, if there is anything I can do to improve this.
All best,
Jeremy