Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: cargo-chef support for patches #64

Open
prestontw opened this issue Jun 1, 2021 · 4 comments
Open

Feature request: cargo-chef support for patches #64

prestontw opened this issue Jun 1, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@prestontw
Copy link
Contributor

Howdy! I work in a medium-large workspace that includes patches to a couple of dependencies (can provide a minimal example if that would be helpful). When trying to use cargo chef cook, it doesn't seem like the patches are included or applied---I'm seeing compilation errors.

Would it be possible to add rust-patches support to cargo-chef?

@prestontw
Copy link
Contributor Author

I think the only thing that is necessary is adding --offline support to the cargo command that is run, which I've attempted to do in #65

@LukeMathWalker LukeMathWalker added the enhancement New feature or request label Jun 5, 2021
@prestontw
Copy link
Contributor Author

I am still running into problems even with --offline support. I think it's because cargo chef is overwriting the rust-patches' lib.rs files. These should still be treated as dependencies---they should not be overwritten. I verified locally that lib.rs is getting replaced with an empty file. My first thought would be to allow a list of directories not to replace, and make the default include rust-patches. I'll try this locally and see if this solves the problem.

@LukeMathWalker
Copy link
Owner

A minimal example would really help here to understand what the issue is and the best way forward to solve it (if possible).

@prestontw
Copy link
Contributor Author

@LukeMathWalker I've verified that prestontw@5825041 fixes the problem for me. I'm planning on making this customizable and reproducing a minimal example. I wanted to show you what worked first, though, in case you had thoughts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants