Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use requests Session for connection pooling to NBNco #43

Closed
lyricnz opened this issue May 24, 2023 · 3 comments
Closed

Use requests Session for connection pooling to NBNco #43

lyricnz opened this issue May 24, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@lyricnz
Copy link
Contributor

lyricnz commented May 24, 2023 •
edited

I think this might speed things up a little
https://requests.readthedocs.io/en/latest/user/advanced/#session-objects
@lyricnz
Copy link
Contributor Author

lyricnz commented May 24, 2023

Unclear whether sessions/urllib3 are thread-safe for ThreadPoolExecutor
psf/requests#2766

@LukePrior LukePrior added the enhancement New feature or request label May 24, 2023
@lyricnz
Copy link
Contributor Author

lyricnz commented May 27, 2023

If they're not thread-safe, maybe could pre-split the list into chunks, and process each chunk in a separate thread (each of which has a Session)

@lyricnz
Copy link
Contributor Author

lyricnz commented May 29, 2023

Resolved by #66

@lyricnz lyricnz closed this as completed May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lyricnz @LukePrior