Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make_pdfs.sh makes a pdf of the README #8

Open
LukeRoantree4815162342 opened this issue Aug 28, 2018 · 2 comments
Open

make_pdfs.sh makes a pdf of the README #8

LukeRoantree4815162342 opened this issue Aug 28, 2018 · 2 comments
Labels
Bash this issue relates to shell script(s) bug Something isn't working help wanted Extra attention is needed

Comments

@LukeRoantree4815162342
Copy link
Owner

change the shell script to exclude the readme

@LukeRoantree4815162342 LukeRoantree4815162342 added bug Something isn't working help wanted Extra attention is needed Bash this issue relates to shell script(s) labels Aug 28, 2018
@ChrisspyB
Copy link
Collaborator

ChrisspyB commented Aug 28, 2018

Rather than explicitly excluding the readme.md (and also contributing.md and any other .md's that sneak their way in) it might be better to generate files into a new folder, and have the bash script run on all .md files in there. This would also be helpful in keeping new worksheets together, and prevent remaking pdfs of existing .mds.

Edit: Though ideally we would just run make-pdf on each <my_new_worksheet.md> as soon as they are created.

@LukeRoantree4815162342
Copy link
Owner Author

That sounds like a much better plan, let's do that. Although I was holding off on integrating md2pdf directly, just in case we switch to something else. I was going to put a PR for python3 compatability, but saw there already has been one since January - unmerged. So we might need to look at switching to something else

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bash this issue relates to shell script(s) bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants