Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Youtube iframe without data-param-* causes warning #132

Closed
naeh opened this issue Aug 10, 2016 · 1 comment
Closed

Youtube iframe without data-param-* causes warning #132

naeh opened this issue Aug 10, 2016 · 1 comment

Comments

@naeh
Copy link

naeh commented Aug 10, 2016

Hello,

when trying de convert html containing youtube iframe without any data-param-* it causes warning, here is an example of youtube tag :
<iframe src="http://www.youtube.com/embed/zA_19bHxEYg" width="425" height="350"></iframe>

here is the warning :
Warning: Invalid argument supplied for foreach() in lullabot\amp\src\Pass\IframeYouTubeTagTransformPass.php on line 161

the problem is that BasePass::getQueryArray returns bool or array but this is not controlled when used in IframeYouTubeTagTransformPass

i think that BasePass::getQueryArray must always return an array (even empty)

@sidkshatriya
Copy link
Contributor

@naeh Thanks for reporting this warning. Its been fixed and a new release tag 1.0.5 been created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants