You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
when trying de convert html containing youtube iframe without any data-param-* it causes warning, here is an example of youtube tag : <iframe src="http://www.youtube.com/embed/zA_19bHxEYg" width="425" height="350"></iframe>
here is the warning : Warning: Invalid argument supplied for foreach() in lullabot\amp\src\Pass\IframeYouTubeTagTransformPass.php on line 161
the problem is that BasePass::getQueryArray returns bool or array but this is not controlled when used in IframeYouTubeTagTransformPass
i think that BasePass::getQueryArray must always return an array (even empty)
The text was updated successfully, but these errors were encountered:
Hello,
when trying de convert html containing youtube iframe without any data-param-* it causes warning, here is an example of youtube tag :
<iframe src="http://www.youtube.com/embed/zA_19bHxEYg" width="425" height="350"></iframe>
here is the warning :
Warning: Invalid argument supplied for foreach() in lullabot\amp\src\Pass\IframeYouTubeTagTransformPass.php on line 161
the problem is that
BasePass::getQueryArray
returns bool or array but this is not controlled when used in IframeYouTubeTagTransformPassi think that
BasePass::getQueryArray
must always return an array (even empty)The text was updated successfully, but these errors were encountered: