-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Composer 2 version for both Dockerfile and Dockerfile9 #72
Comments
Maybe use semver and add to the README that the new major version supports Composer 2 only? |
I don't really have much to add here other than +1 for using semver and building some images with Composer 2 installed in them. And if there's anything I can do help make that happen let me know! |
At this point I think Composer 2 had resolved most of the issues with projects, I would prefer to have it updated by default. |
Update to composer 2 |
I needed to force it in some steps here: #79 I think we are at a point where we should just use composer 2 in the images. I'm actually creating a follow up issue because it's not just composer, it's the PHP version, the node version, etc. |
This was done at #81. |
Is your feature request related to a problem? Please describe.
The current images only support Composer 1, and even with hirak/prestissimo, the speed of dependency calculation and download are not comparable with Composer 2.
Describe the solution you'd like
I think this images should support Composer 2, but keeping Composer 1 to avoid breaking compatibility with existing services using the current images.
Describe alternatives you've considered
The clearer workaround, meanwhile, is to update composer and remove hirak/prestissimo on the very first step with the following:
This should update the image to Composer 2, removing
hirak/prestissimo
, until there is an alternative image using Composer 2.Additional context
After a few months, Composer 2 still throw some issues in projects with Composer 1 dependencies. One example are
phpro/grumphp:0.16
.The upgrade from Composer 1 to Composer 2 is not trivial and easy in some cases.
There should be, in my opinion, a clear distinction between the images running composer 1, the current ones, and the new images running composer 2, to avoid breaking compatibility with existing projects.
The text was updated successfully, but these errors were encountered: