Unable to add a new mpx type on PHP 7.3 #147
Comments
Just to be sure. It's not the same scenario of this PR, is it? #145. Seems completely different, but just double checking 👍 |
Yeah, not the same, in this one unserialize() fails with a parse error notice. |
Does this still happen? Asking because this was raised as an outstanding PHP compatibility issue in https://www.drupal.org/project/drupal/issues/3106075 |
Good question! @m4olivei have any of the sites we know of using this upgraded to PHP 7.3 or 7.4 yet? When I last worked on this I believe we were on 7.2 and I only ran into this on my local. |
Our sites that are using media_mpx are on 7.1 and 7.2. There are plans to update to 7.3, but there isn't a lot of momentum on that, and we're dependent on our infrastructure group. All that is to say, we don't have a solid timeline. FWIW, I updated my local to PHP 7.3 and tested this. The site is currently on Drupal 8.7.7 and the error still occurs:
As a sidenote, my understanding is that Drupal core isn't ready for PHP 7.4 yet. |
When running with PHP 7.3, the form cache throws an error on unserialize() when trying to add an mpx media type. It works fine in PHP 7.2. I can add other media types, which makes me wonder if #ajax is part of the issue. My closest result is symfony/symfony#29459 and https://bugs.php.net/bug.php?id=77302 which may mean something is broken in <7.2, but just silently failing.
The text was updated successfully, but these errors were encountered: