-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transient signal classes #115
Comments
Any opinions @LMSC-NTappy @jordiferrero @gkusch? |
It's true. I myself mostly (only) use the general Signal1D/Signal2D stock classes. I guess when hyperspy 1.7 is out we'll add dedicated axes for spectroscopy setups (non-linear) and that's going to be a good start. The question is what kind of analysis is needed specifically for luminescence / TR spectra ? A "true luminescence color" widget would be nice...
Couldn't suggest anything better. Btw I just submitted a pull request for loading hamamatsu streak map into hyperspy :)
Generally speaking I am in favour of keeping the name close to the data and not the detector, most transient spectra are recorded with TCSPCs I think... |
I personally have no strong opinions on the naming of the classes as I have never used them yet. |
We missed something when introducing the transient signal classes last year (and no one seems to have used them so far? Anyway there are no specific functions). At the moment, we have a set of Signal2D classes for transients:
That is correct for a streak camera image <x,y|E,t>, but not for a pure transient <x,y|t> (without spectral information).
The
...Transient
classes should in fact be Signal1D, while there should be an additional set of classes...TransientSpectrum
for Streak camera images. Any oppinions? I would propose to fix it for the v0.2 release.(see original discussion in #5 (comment) )
The text was updated successfully, but these errors were encountered: