Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

harden security of github actions #76

Closed
1 of 2 tasks
jlaehne opened this issue May 2, 2021 · 4 comments
Closed
1 of 2 tasks

harden security of github actions #76

jlaehne opened this issue May 2, 2021 · 4 comments

Comments

@jlaehne
Copy link
Contributor

jlaehne commented May 2, 2021

See hyperspy/hyperspy#2727

We should:

@jlaehne
Copy link
Contributor Author

jlaehne commented Jun 10, 2022

Restricted permissions for Actions:

  • allow only selected non-lumispy-workflows
  • workflows have only read permissions
  • actions cannot create or approve PRs

@jordiferrero
Copy link
Contributor

The only actions that use secrets in lumispy are in the release.yml actions:

  • GITHUB_TOKEN to create a new release
  • TWINE_USERNAME & TWINE_PASSWORD for submitting the new version to PyPI.

@jlaehne what do you want to do with this? I've been reading a bit more on pinning actions, but not sure how to proceed.

@jlaehne
Copy link
Contributor Author

jlaehne commented Sep 18, 2022

I am not fully sure either, but think that for these actions it should be OK as it is. In that case we could close this issue.

@ericpre I think we never implemented pinning for HyperSpy either?

@ericpre
Copy link
Contributor

ericpre commented Sep 19, 2022

From checking the current workflows, the ones with permissions: contents: write are not using third party actions, which means that this is fine as it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants