feat(h5p-server): hub now localizable #1200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JPSchellenberg
approved these changes
Mar 19, 2021
sr258
added a commit
that referenced
this pull request
Mar 21, 2021
* feat(h5p-server): support for Hub locales * feat(h5p-server): added auto-translated Hub locale and tests * feat(h5p-server): added localization to h5p-rest-example * feat(h5p-server): added title to hub locale * feat(h5p-server): hub localization works for untranslated content types
sr258
added a commit
that referenced
this pull request
Mar 22, 2021
* chore(deps): update dependency eslint-plugin-react-hooks to v4 * chore(deps): lock file maintenance * chore(deps): update dependency @types/mongodb to v3.6.10 * chore(deps): update dependency @types/react to v17.0.3 * chore(deps): update dependency mockdate to v3.0.3 * chore(deps): update dependency @types/express-serve-static-core to v4.17.19 * chore(deps): update dependency @types/node to v14.14.35 * chore(deps): update typescript-eslint monorepo to v4.18.0 * fix(deps): update dependency aws-sdk to v2.864.0 * fix(deps): update dependency mongodb to v3.6.5 * fix(deps): update dependency aws-sdk to v2.865.0 * fix(deps): update font awesome * chore(deps): update dependency @types/jest to v26.0.21 * chore(deps): update dependency ts-jest to v26.5.4 * fix(deps): update dependency aws-sdk to v2.866.0 * chore(deps): update dependency mockdate to v3.0.4 * fix(deps): update dependency aws-sdk to v2.867.0 * chore(deps): update dependency @testing-library/user-event to v13 * chore(deps): update dependency start-server-and-test to v1.12.1 * feat(h5p-server): hub now localizable (#1200) * feat(h5p-server): support for Hub locales * feat(h5p-server): added auto-translated Hub locale and tests * feat(h5p-server): added localization to h5p-rest-example * feat(h5p-server): added title to hub locale * feat(h5p-server): hub localization works for untranslated content types * chore(deps): update dependency @testing-library/user-event to v13.0.3 * fix(deps): update dependency aws-sdk to v2.868.0 * chore(deps): update dependency @testing-library/user-event to v13.0.6 * refactor(h5p-server): Updated h5p-server-hub language file for German * refactor(h5p-server): Updated h5p-server-hub language file for German refactor(h5p-server): Updated h5p-server-hub language file for German refactor(h5p-server): Updated h5p-server-hub language file for German refactor(h5p-server): Updated h5p-server-hub language file for German Co-authored-by: Sebastian Rettig <serettig@posteo.de> Co-authored-by: Weblate <noreply@weblate.org> * Update translation files Updated by "Squash Git commits" hook in Weblate. Translation: Lumi Education/h5p-server-hub Translate-URL: https://translate-h5p.tk/weblate/projects/lumi-education/h5p-server-hub/ Co-authored-by: Weblate <noreply@weblate.org> Co-authored-by: Sebastian Rettig <serettig@posteo.de> * chore(deps): update dependency remark-validate-links to v10.0.4 * feat(h5p-server): localization of library names (#1205) * feat(h5p-server): localization of library names * feat(h5p-rest-example): added library localization to rest example * docs(all): added package docs * v7.4.0 Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Sebastian Rettig <sr258@users.noreply.github.com> Co-authored-by: translate-h5p <47823891+translate-h5p@users.noreply.github.com> Co-authored-by: Weblate <noreply@weblate.org> Co-authored-by: Sebastian Rettig <serettig@posteo.de> Co-authored-by: Lumi <c@Lumi.education>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The H5P Hub is now localizable like the rest of the H5P internals. I've implemented it in a way that is non-breaking. You have to opt-in to the localization and add the 'hub' namespace to the i18n system for it to work.
I'd like to merge it into master, do a manual go with Weblate and only then publish it.