Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Implement support for single-line comments using // #400

Closed
4 tasks done
Tracked by #404 ...
Luna-Klatzer opened this issue Feb 4, 2023 · 1 comment · Fixed by #404 or #419
Closed
4 tasks done
Tracked by #404 ...

[Feature] Implement support for single-line comments using // #400

Luna-Klatzer opened this issue Feb 4, 2023 · 1 comment · Fixed by #404 or #419
Assignees
Labels
feature New feature or enhancement
Milestone

Comments

@Luna-Klatzer
Copy link
Member

Luna-Klatzer commented Feb 4, 2023

Is there an existing proposal for this?

  • I have searched the existing issues

This feature does not exist in the latest version

  • I am using the latest version

Proposal

Due to the active buildup and development of the Kipper Parser, only /* */ multi-line comments were implemented at first, only allowing the use of comments that had an explicit start and end.

This is not consistent with other languages though, where both // and /* */ are usually supported. As such, this issue proposes the implementation of single-line comments in the following format:

// ... [\n]

The end of the comment will like in other languages, such as TypeScript, Java or C#, be defined as the invisible line-end char (\n, \r\n or \r).

Exact behaviour / changes you want

  • Implement syntax support for single-line comments.
  • Resolve any bugs associated with newline recognition in the Kipper Parser.
@Luna-Klatzer Luna-Klatzer added feature New feature or enhancement question Further information is requested labels Feb 4, 2023
@Luna-Klatzer Luna-Klatzer self-assigned this Feb 4, 2023
@Luna-Klatzer Luna-Klatzer added this to the v0.11.0 milestone Feb 4, 2023
@Luna-Klatzer Luna-Klatzer removed the question Further information is requested label Feb 4, 2023
@Luna-Klatzer Luna-Klatzer modified the milestones: v0.11.0, v0.10.0 Feb 10, 2023
@Luna-Klatzer
Copy link
Member Author

Implemented by #404 and should be released in the next version.

@Luna-Klatzer Luna-Klatzer mentioned this issue Feb 19, 2023
13 tasks
@Luna-Klatzer Luna-Klatzer linked a pull request Feb 19, 2023 that will close this issue
13 tasks
@Luna-Klatzer Luna-Klatzer mentioned this issue Feb 19, 2023
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment