Fixed NULL character bug when writing generated TypeScript code onto files using the utf16le encoding
#114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng the `utf16le` encoding
Luna-Klatzer
added
bug
…114-fix-wrong-utf16-write
Luna-Klatzer
changed the title
utf16le encodingutf16le encoding
This was referenced May 21, 2022
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of change does this PR perform?
Summary
Fixed NULL character issue when writing generated code onto files using the
utf16leencoding.Changes
utf16lefile writing issue in@kipper/cli.Does this PR create new warnings?
No.
Changelog
Changed
utf16leencoding. From now on a bufferwill be created using the proper encoding (also for
asciiandutf8) that should be properly writable to a file.Linked other issues or PRs
No linked issues.