Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rounded flags as well #58

Closed
vanlooverenkoen opened this issue Aug 3, 2021 · 3 comments
Closed

Add rounded flags as well #58

vanlooverenkoen opened this issue Aug 3, 2021 · 3 comments
Assignees
Labels
enhancement New feature or request
Projects

Comments

@vanlooverenkoen
Copy link

Something like this:

image

@Rohithgilla12
Copy link

@vanlooverenkoen You can wrap it around with ClipRRect

Something like this

ClipRRect(
    borderRadius:
        BorderRadius.circular(AppDimensions.mainSpace),
    child: Flag.fromCode(
      FlagsCode.US,
      height: 32,
      width: 32,
      fit: BoxFit.fill,
    ),
  ),
  

@vanlooverenkoen
Copy link
Author

Yes but that would not work for every flag. It will cut off parts of the flag that are important for some countries. (custom rounded icons would be the better solution in my opinion)

@LunaGao LunaGao added this to To do in v6.0.0 Jan 10, 2022
@LunaGao LunaGao self-assigned this Jan 10, 2022
@LunaGao LunaGao moved this from To do to review in v6.0.0 Jan 10, 2022
@LunaGao LunaGao added the enhancement New feature or request label Jan 10, 2022
@LunaGao
Copy link
Owner

LunaGao commented Jan 16, 2022

fixed in v6.0.0

@LunaGao LunaGao closed this as completed Jan 16, 2022
@LunaGao LunaGao moved this from review to Done in v6.0.0 Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

No branches or pull requests

3 participants