Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI(Neovide) crashes due to invalid 'guifont' option #4446

Closed
wy-z opened this issue Dec 25, 2023 · 3 comments
Closed

GUI(Neovide) crashes due to invalid 'guifont' option #4446

wy-z opened this issue Dec 25, 2023 · 3 comments
Labels
bug Something isn't working stale

Comments

@wy-z
Copy link
Contributor

wy-z commented Dec 25, 2023

Problem description

  • The value of 'guifont' is unreasonable; 'monospace:h17' is not a universally pre-installed font on most devices.
  • Neovide will cache the font when there is a change in 'guifont' to improve rendering performance, and an incorrect value can cause it to malfunction.

An erroneous 'guifont' configuration may lead to GUI operational errors;
I have also reconfigured 'guifont' in my personal settings, but the default configuration in 'lvim' still triggers a 'guifont' change once, see https://github.com/LunarVim/LunarVim/blob/master/lua/lvim/config/settings.lua#L22 .

Neovide: https://github.com/neovide/neovide
Neovide font caching: https://github.com/neovide/neovide/blob/af9869bd6d8d3434b187e29f85032ee74e40b536/src/renderer/fonts/caching_shaper.rs#L44C6-L44C19

LunarVim version

master-b124e8c3

Neovim version (>= 0.9.1)

v0.9.4

Terminal name

iTerm2

Operating system/version

14.2.1 (23C71)

Steps to reproduce

No response

Screenshots

image
@wy-z wy-z added the bug Something isn't working label Dec 25, 2023
@wy-z wy-z changed the title Invalid 'guifont' option crash Neovide GUI crashes due to invalid 'guifont' option Dec 25, 2023
@wy-z wy-z changed the title GUI crashes due to invalid 'guifont' option GUI(Neovide) crashes due to invalid 'guifont' option Dec 25, 2023
@xinleibird
Copy link

Same issue, the reason for this is a feature that was added in Neovide v0.12.0: "Report error when setting a wrong guifont value" (neovide/neovide#2089), in macOS Sonoma "monospace" is not considered a legal font in Neovide v0.12.0.

Probably shouldn't set guifont in LunarVim? because LunarVim is indeed not related to the GUI?

Copy link
Contributor

This issue is stale because it has been open for 50 days with no activity.

@github-actions github-actions bot added the stale label Feb 14, 2024
@wy-z
Copy link
Contributor Author

wy-z commented Feb 18, 2024

#4447

@wy-z wy-z closed this as completed Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale
Projects
None yet
Development

No branches or pull requests

2 participants