Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove typeRoots from tsconfig.json #22

Closed
LunatiqueCoder opened this issue Nov 13, 2021 · 0 comments · Fixed by #25
Closed

Remove typeRoots from tsconfig.json #22

LunatiqueCoder opened this issue Nov 13, 2021 · 0 comments · Fixed by #25
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
v1.1.0
Milestone
v1.1.0

Comments

@LunatiqueCoder
Copy link
Owner

Is your feature request related to a problem? Please describe.
We are misusing typeRoots and they are not working properly anyway. Should be a breaking change with typescript@4.5.0 according to microsoft/TypeScript#37708

Describe the solution you'd like
Simply remove typeRoots from tsconfig.json.
@LunatiqueCoder LunatiqueCoder added enhancement New feature or request good first issue Good for newcomers labels Nov 13, 2021
@LunatiqueCoder LunatiqueCoder added this to the v1.1.0 milestone Nov 13, 2021
@LunatiqueCoder LunatiqueCoder added this to To do in v1.1.0 via automation Nov 13, 2021
@LunatiqueCoder LunatiqueCoder mentioned this issue Nov 14, 2021
Merged
@LunatiqueCoder LunatiqueCoder linked a pull request Nov 14, 2021 that will close this issue
Remove typeRoots and update tsconfig.json template #25
Merged
v1.1.0 automation moved this from To do to Done Nov 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
No open projects
v1.1.0
Done
Milestone
v1.1.0
Development

Successfully merging a pull request may close this issue.

Remove typeRoots and update tsconfig.json template LunatiqueCoder/luna
1 participant
@LunatiqueCoder