Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some spaces not getting added during parsing #344

Closed
jzohrab opened this issue Mar 16, 2024 · 8 comments
Closed

Some spaces not getting added during parsing #344

jzohrab opened this issue Mar 16, 2024 · 8 comments
Assignees
@jzohrab
Labels
bug Something isn't working fixed Fixed in develop or master, to be launched.

Comments

@jzohrab
Copy link
Collaborator

jzohrab commented Mar 16, 2024

From mycheze in discord:

Image

and I have the epub, text file, and his lute.db in discord.
@jzohrab jzohrab added the bug Something isn't working label Mar 16, 2024
@jzohrab jzohrab self-assigned this Mar 16, 2024
@jzohrab
Copy link
Collaborator Author

jzohrab commented Mar 17, 2024 •
edited
Loading

Did a test import of the text file, looks ok:

Image

@jzohrab
Copy link
Collaborator Author

jzohrab commented Mar 17, 2024

epub import, spaces missing:

Image

@jzohrab
Copy link
Collaborator Author

jzohrab commented Mar 17, 2024

Text in the page in Lute, from the epub:

Odpovědi na tyto a mnohé další otázky hledá v novém senzačním životopise nazvanémŽivot a lži Albuse BrumbálaRita Holoubková. Exkluzivní rozhovor s ní přináší Betty Braithwaiteová na straně 13.

@jzohrab
Copy link
Collaborator Author

jzohrab commented Mar 17, 2024

Here's the epub, opened in mac books app (or whatever). The words causing problems are non-italics in a string of italics:

Image

possibly the epub library is getting confused at the boundaries for some reason ...

@jzohrab
Copy link
Collaborator Author

jzohrab commented Mar 17, 2024

Source html in the epub is this:

<p class="Clanek1"><span lang="CS">Odpovědi na tyto a mnohé další otázky hledá v novém senzačním životopise
nazvaném </span><span lang="CS" class="calibre8">Život a lži Albuse Brumbála</span><span lang="CS"> Rita Holoubková. Exkluzivní rozhovor s ní přináší Betty Braithwaiteová
na straně 13.</span></p>

@jzohrab jzohrab mentioned this issue Mar 17, 2024
Closed
@jzohrab
Copy link
Collaborator Author

jzohrab commented Mar 17, 2024

Space removal is happening in the source epub library, ticket opened there (sakolkar/openepub#2). This issue is blocked until that one is resolved.

@jzohrab jzohrab changed the title Some spaces not getting added during parsing Some spaces not getting added during parsing -- blocked by sakolkar/openepub/issues/2 Mar 17, 2024
@jzohrab jzohrab changed the title Some spaces not getting added during parsing -- blocked by sakolkar/openepub/issues/2 Some spaces not getting added during parsing Mar 30, 2024
@jzohrab jzohrab removed the blocked label Mar 30, 2024
@jzohrab
Copy link
Collaborator Author

jzohrab commented Mar 30, 2024

openepub 0.0.8 is out, this should be fixed. Bumping the dependency.

@jzohrab jzohrab added the fixed Fixed in develop or master, to be launched. label Mar 30, 2024
@jzohrab
Copy link
Collaborator Author

jzohrab commented Apr 26, 2024

Launched in 3.3.2.

@jzohrab jzohrab closed this as completed Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jzohrab jzohrab

Labels
bug Something isn't working fixed Fixed in develop or master, to be launched.
Projects
Lute-v3
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jzohrab