Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import problems #55

Closed
grofzero opened this issue Apr 26, 2016 · 9 comments
Closed

import problems #55

grofzero opened this issue Apr 26, 2016 · 9 comments
Assignees
Labels
Milestone

Comments

@grofzero
Copy link

Hi,

I tried to install the new ES6 module with jspm, but I had some problems with it. The npm version is not the same as the github version and it contains a require statement in the http-interception.js, so it breaks the code, but I didn't have luck with the github version either. In the index.js it tries to load the './http-interception' but it doesn't load the index.js in the http-interception folder instead it tries to load the http-interception.js file which soesn't exist. Could you please fix these problems, or tell me if I'm doing something wrong?

Thank you

@maennchen
Copy link
Contributor

I was only using it with Babel until now. (With webpack & browserify)

Babel replaces all import / export statements with require / module.exports.
It seem as those two are not alike (For example not loading a index.js automatically)

@maennchen maennchen added the bug label Apr 27, 2016
@maennchen maennchen self-assigned this Apr 27, 2016
@maennchen
Copy link
Contributor

A solution to this problem could be to run the test multiple times. Once for every environement.

Environements:

  • Jspm
  • Webpack
  • Browserify

Would you be able to provide a PR?

@grofzero
Copy link
Author

Of course, as soon as I can

@maennchen
Copy link
Contributor

I already had the time to build a solution. I'll provide a PR in a few minutes. I'd be happy if you could test it.

@grofzero
Copy link
Author

Great, it seems to be working, thank you very much:) Could you publish it to npm?

@maennchen maennchen added this to the v2.1.4 milestone Apr 27, 2016
@maennchen
Copy link
Contributor

It's published. It may take a few minutes to refresh all npm etc. caches.

@grofzero
Copy link
Author

Thank you very much, but I still cannot see the 2.1.4 version in npm. Could you check it please?

@maennchen
Copy link
Contributor

@elmerbulthuis: The npm deployment is failing again on travis. Could you check and deploy 2.1.4?

@maennchen
Copy link
Contributor

@grofzero: Npm still doesn't find v.2.1.4. But you can use the newer v2.1.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants